Commits on Aug 25, 2022

1. Close mozilla-mobile#12689: Make sharing images work with Direct Share …

   Image sharing currently only works when sharing to an app but not when
   using the Android Direct Share feature, where it fails with a
   SecurityException.
   
   "Direct Share" is what Android calls the app created shortcuts,
   i.e. individual chats from a messaging application.
   
   The code pretty much already does the right thing (i.e. setting
   the FLAG_GRANT_READ_URI_PERMISSION on the target intent as well as the
   Chooser action, as described in ACTION_CHOOSE Api docs[1]) but there's
   some platform internals that seem to go wrong here but we can work
   around it with this patch.
   
   https://issuetracker.google.com/issues/151386328 describes a similar
   Problem, especially mozilla-mobile#12 in there offers a similar workaround and an
   explanation:
   
     The underlying problem is that ACTION_SEND is using EXTRA_STREAM for the
     content URI. But the FLAG_GRANT_*_URI_PERMISSION mechanism only works
     with URIs in Intent.data and Intent.clipData. The framework contains
     some code that tries to work around this limitation. But it doesn't
     handle this particular case. Intent.createChooser() migrates the flags
     and data/clipData from the target Intent, but it does so before the
     framework had a chance to fix up the target Intent via Intent.migrateExtraStreamToClipData().
   
   And indeed moving the clipData into the inner intent makes Direct Share
   work and preserves the image preview in the Intent.
   
   [1] file:///<SDK-DIR>/docs/reference/android/content/Intent.html#ACTION_CHOOSER
     If you need to grant URI permissions through a chooser, you must specify
     the permissions to be granted on the ACTION_CHOOSER Intent in addition to
     the EXTRA_INTENT inside. This means using setClipData(ClipData) to
     specify the URIs to be granted as well as FLAG_GRANT_READ_URI_PERMISSION
     and/or FLAG_GRANT_WRITE_URI_PERMISSION as appropriate.

   

   Bubu committed Aug 25, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for f7d3d81
   • Browse repository at this point

   Copy the full SHA

   f7d3d81 View commit details

   Browse the repository at this point in the history