Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

For #8754: Media Files Not Indexed To Media Storage #6719

Conversation

kglazko
Copy link
Contributor

@kglazko kglazko commented Apr 20, 2020


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@kglazko kglazko changed the title For8754MediaFilesNotIndexedToMediaStorage For #8754: Media Files Not Indexed To Media Storage Apr 20, 2020
@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #6719 into master will decrease coverage by 0.32%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6719      +/-   ##
============================================
- Coverage     77.13%   76.81%   -0.33%     
+ Complexity     4720     4652      -68     
============================================
  Files           621      633      +12     
  Lines         23383    23051     -332     
  Branches       3409     3322      -87     
============================================
- Hits          18037    17707     -330     
- Misses         3931     3960      +29     
+ Partials       1415     1384      -31     
Impacted Files Coverage Δ Complexity Δ
.../feature/downloads/AbstractFetchDownloadService.kt 62.83% <0.00%> (-0.28%) 42.00 <0.00> (ø)
...onents/lib/crash/notification/CrashNotification.kt 94.11% <0.00%> (-0.17%) 2.00% <0.00%> (ø%)
...onents/support/sync/telemetry/BaseGleanSyncPing.kt 100.00% <0.00%> (ø) 11.00% <0.00%> (ø%)
...ngine/system/permission/SystemPermissionRequest.kt
...omponents/concept/fetch/interceptor/Interceptor.kt
...a/components/browser/engine/system/SystemEngine.kt
...ponents/browser/engine/system/matcher/WhiteList.kt
.../java/mozilla/components/concept/fetch/Response.kt
...onents/browser/engine/system/matcher/UrlMatcher.kt
...mponents/browser/engine/system/SystemEngineView.kt
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d5bf63...dd20882. Read the comment docs.

@kglazko kglazko force-pushed the Issue8754MediaFilesNotIndexedToMediaStorage branch from 30ce495 to 6293247 Compare May 21, 2020 01:30
@Amejia481
Copy link
Contributor

Closed in favour of #7231

@Amejia481 Amejia481 closed this Jun 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants