Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Closes #7230: Add downloads to the system download database for devices older than Q #7231

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

Amejia481
Copy link
Contributor


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@Amejia481 Amejia481 added the 🕵️‍♀️ needs review PRs that need to be reviewed label Jun 3, 2020
@Amejia481 Amejia481 requested a review from kglazko June 3, 2020 20:14
@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #7231 into master will increase coverage by 0.13%.
The diff coverage is 58.82%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7231      +/-   ##
============================================
+ Coverage     77.22%   77.36%   +0.13%     
- Complexity     4820     5049     +229     
============================================
  Files           649      674      +25     
  Lines         24025    24705     +680     
  Branches       3536     3641     +105     
============================================
+ Hits          18554    19113     +559     
- Misses         4008     4077      +69     
- Partials       1463     1515      +52     
Impacted Files Coverage Δ Complexity Δ
.../feature/downloads/AbstractFetchDownloadService.kt 71.27% <58.82%> (+2.18%) 64.00 <2.00> (+1.00)
...rt/migration/session/InMemorySessionStoreParser.kt 92.00% <0.00%> (-2.12%) 8.00% <0.00%> (ø%)
...onents/feature/app/links/RedirectDialogFragment.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
.../mozilla/components/service/fretboard/Fretboard.kt 100.00% <0.00%> (ø) 21.00% <0.00%> (?%)
...ervice/fretboard/scheduler/jobscheduler/SyncJob.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...mponents/service/fretboard/JSONExperimentParser.kt 95.65% <0.00%> (ø) 27.00% <0.00%> (?%)
...s/service/fretboard/ExperimentDownloadException.kt 100.00% <0.00%> (ø) 2.00% <0.00%> (?%)
...omponents/service/fretboard/ExperimentEvaluator.kt 87.93% <0.00%> (ø) 39.00% <0.00%> (?%)
.../scheduler/workmanager/WorkManagerSyncScheduler.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...la/components/feature/app/links/AppLinkRedirect.kt 88.88% <0.00%> (ø) 16.00% <0.00%> (?%)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a28772...4162a2b. Read the comment docs.

Copy link
Contributor

@kglazko kglazko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good besides a nit/question I mentioned

@Amejia481
Copy link
Contributor Author

bors r=kglazko,NotWoods

@bors
Copy link

bors bot commented Jun 4, 2020

Build succeeded:

@bors bors bot merged commit a8e7f3c into mozilla-mobile:master Jun 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕵️‍♀️ needs review PRs that need to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants