This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 473
Closes #7230: Add downloads to the system download database for devices older than Q #7231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7231 +/- ##
============================================
+ Coverage 77.22% 77.36% +0.13%
- Complexity 4820 5049 +229
============================================
Files 649 674 +25
Lines 24025 24705 +680
Branches 3536 3641 +105
============================================
+ Hits 18554 19113 +559
- Misses 4008 4077 +69
- Partials 1463 1515 +52
Continue to review full report at Codecov.
|
NotWoods
suggested changes
Jun 4, 2020
...downloads/src/main/java/mozilla/components/feature/downloads/AbstractFetchDownloadService.kt
Outdated
Show resolved
Hide resolved
kglazko
approved these changes
Jun 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good besides a nit/question I mentioned
...downloads/src/main/java/mozilla/components/feature/downloads/AbstractFetchDownloadService.kt
Outdated
Show resolved
Hide resolved
kglazko
reviewed
Jun 4, 2020
...loads/src/test/java/mozilla/components/feature/downloads/AbstractFetchDownloadServiceTest.kt
Outdated
Show resolved
Hide resolved
NotWoods
approved these changes
Jun 4, 2020
4 tasks
…abase for devices older than Q
bors r=kglazko,NotWoods |
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
After merge