This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
For #8123: Fix history title crash #8174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonalmeida
approved these changes
Aug 20, 2020
| @@ -680,7 +680,13 @@ class GeckoEngineSession( | |||
| session: GeckoSession, | |||
| historyList: GeckoSession.HistoryDelegate.HistoryList | |||
| ) { | |||
| val items = historyList.map { HistoryItem(title = it.title, uri = it.uri) } | |||
| val items = historyList.map { | |||
| val title: String? = it.title | |||
There was a problem hiding this comment.
Could you leave a comment here why we are doing this and link to the GV bug that fixes the issue.
NotWoods
force-pushed
the
8123_history-crash
branch
from
389c291
to
0b385bd
Compare
|
bors r=jonalmeida |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
After merge