Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

GeckoEngineSession#onHistoryStateChange: it.title must not be null #8123

Closed
grigoryk opened this issue Aug 14, 2020 · 3 comments · Fixed by #8174
Closed

GeckoEngineSession#onHistoryStateChange: it.title must not be null #8123

grigoryk opened this issue Aug 14, 2020 · 3 comments · Fixed by #8174
Labels
💥 crash <engine-gecko> Component: browser-engine-gecko

Comments

@grigoryk
Copy link
Contributor

grigoryk commented Aug 14, 2020

From https://sentry.prod.mozaws.net/operations/firefox/issues/9265306/?query=is%3Aunresolved%20release%3Aorg.mozilla.firefox-79.0.4

Pretty decent volume of crashes.

java.lang.IllegalStateException: it.title must not be null
    at kotlin.jvm.internal.ArrayIteratorKt.checkExpressionValueIsNotNull(ArrayIterator.kt:1)
    at mozilla.components.browser.engine.gecko.GeckoEngineSession$createHistoryDelegate$1.onHistoryStateChange(GeckoEngineSession.kt:4)
    at org.mozilla.geckoview.GeckoSession$1.handleMessage(GeckoSession.java:24)
    at org.mozilla.geckoview.GeckoSession$1.handleMessage(GeckoSession.java:1)
    at org.mozilla.geckoview.GeckoSessionHandler.handleMessage(GeckoSessionHandler.java:2)
    at org.mozilla.gecko.EventDispatcher$3.run(EventDispatcher.java:1)
    at android.os.Handler.handleCallback(Handler.java:873)
    at android.os.Handler.dispatchMessage(Handler.java:99)
    at android.os.Looper.loop(Looper.java:216)
    at android.app.ActivityThread.main(ActivityThread.java:7266)
    at java.lang.reflect.Method.invoke(Method.java)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:494)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:975)

┆Issue is synchronized with this Jira Task

@grigoryk
Copy link
Contributor Author

Introduced in #7024, where we falsely assume that GV won't pass us null titles.

@grigoryk
Copy link
Contributor Author

cc @jonalmeida @NotWoods

@NotWoods NotWoods self-assigned this Aug 20, 2020
@NotWoods NotWoods added <crash> Component: lib-crash <engine-gecko> Component: browser-engine-gecko 💥 crash and removed <crash> Component: lib-crash labels Aug 20, 2020
@agi
Copy link
Contributor

agi commented Aug 20, 2020

NotWoods added a commit to NotWoods/android-components that referenced this issue Aug 20, 2020
NotWoods added a commit to NotWoods/android-components that referenced this issue Aug 21, 2020
bors bot pushed a commit that referenced this issue Aug 21, 2020
8174: For #8123: Fix history title crash r=jonalmeida a=NotWoods



Co-authored-by: Tiger Oakes <toakes@mozilla.com>
@jonalmeida jonalmeida linked a pull request Aug 21, 2020 that will close this issue
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💥 crash <engine-gecko> Component: browser-engine-gecko
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants