-
Notifications
You must be signed in to change notification settings - Fork 473
Closes #1340 - Add HistoryState to content state #7024
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7024 +/- ##
============================================
- Coverage 77.16% 77.09% -0.07%
- Complexity 4632 4774 +142
============================================
Files 628 627 -1
Lines 22958 23475 +517
Branches 3342 3434 +92
============================================
+ Hits 17716 18099 +383
- Misses 3856 3951 +95
- Partials 1386 1425 +39
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick review so far and this looks great! 🎉 Two things left and we can merge:
- Needs some tests for the
EngineSession
s and theEngineObserver
. - Update the issue ID in the comment.
7c9d929
to
e42dbe8
Compare
@NotWoods Nice! I think we're still missing tests for the GeckoEngineSession before we can merge, those should be straight-forward. 🙂 |
e42dbe8
to
1a84e76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
⚡
Build succeeded: |
Pull Request checklist
After merge