Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Closes issue #8202: Increase downloadJobState.currentBytesCopied in copyInChunks. #8203

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Closes issue #8202: Increase downloadJobState.currentBytesCopied in copyInChunks. #8203

merged 1 commit into from
Aug 24, 2020

Conversation

Amejia481
Copy link
Contributor

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@Amejia481 Amejia481 added the 🕵️‍♀️ needs review PRs that need to be reviewed label Aug 24, 2020
@Amejia481 Amejia481 requested a review from kglazko August 24, 2020 13:50
@Amejia481 Amejia481 mentioned this pull request Aug 24, 2020
Closed
kglazko
kglazko approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@kglazko kglazko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Pixel 4 with Fenix master that downloads were showing as failing on last Saturday and it is working for me. PR looks good, thanks for adding the test.

@kglazko
Copy link
Contributor

kglazko commented Aug 24, 2020

Oh be sure to resolve the conflicts with the changelog

@Amejia481
Copy link
Contributor Author

Thanks for the review :)
bors r=kglazko

@bors
Copy link

bors bot commented Aug 24, 2020

Build succeeded:

@bors bors bot merged commit c03945b into mozilla-mobile:master Aug 24, 2020
@kglazko kglazko removed the 🕵️‍♀️ needs review PRs that need to be reviewed label Aug 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kglazko kglazko kglazko approved these changes

Assignees

@kglazko kglazko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Amejia481 @kglazko