Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Investigate heuristics on how frequently visited top sites should appear #14302

Closed
gabrielluong opened this issue Aug 27, 2020 · 8 comments
Closed
Assignees
Labels
eng:qa:verified QA Verified Feature:Shortcuts Top Sites/Topsites on the Firefox home page pin Issues, features, improvements that are still valid

Comments

@gabrielluong
Copy link
Member

gabrielluong commented Aug 27, 2020

Currently, frequently visited top sites will appear as soon as they're visited on a fresh profile. If you don't have any user pinned sites and you visit 10+ different web sites, you will see them all upon on your home screen.

Perhaps, we should add some heuristic on when a visited site should appear as a top sites. For example, we add a min visited requirement before it qualifies as a frequently visited top site.

  • Investigate what ios does (possibly desktop) (<1 day)
  • work with UX on what we want to do (1 day)
  • Run the ideas from UX by AS (<1 day)

┆Issue is synchronized with this Jira Task

@gabrielluong gabrielluong added the Feature:Shortcuts Top Sites/Topsites on the Firefox home page label Aug 27, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Aug 27, 2020
@gabrielluong gabrielluong added needs:UX-investigation Issues where UX needs to define or scope a solution or determine feasibility and removed needs:triage Issue needs triage labels Aug 27, 2020
@jonalmeida
Copy link
Contributor

Maybe also consider how often we update the frecent sites? On a fresh profile at least, it seems like we're always changing the top sites every time a page is loaded, so when you go to the home screen (which is a lot with the current UX), it feels a bit jarring to have a items moving around so often.

For example, a top site in the 3rd position is now in the 5th after visiting another site and returning to the home screen.

@vesta0
Copy link
Collaborator

vesta0 commented Aug 27, 2020

As part of this investigation, it would be great to see find out how desktop does it.

@gabrielluong
Copy link
Member Author

gabrielluong commented Oct 8, 2020

In Desktop, this is the frencey threshold used to determine if a visited site should be displayed as a top site. https://searchfox.org/mozilla-central/rev/919607a3610222099fbfb0113c98b77888ebcbfb/browser/components/newtab/lib/TopSitesFeed.jsm#79

From application services, each top sites can return a frecency score (needs to be added in AS). I spoke to mardak briefly about it: frecency of a typed in url gets a frecency score of… 2000 vs a link visit gets frecency score of 100

@gabrielluong
Copy link
Member Author

@topotropic @vesta0 To summarize my investigation, desktop currently shows a visited site as a top site when the user has a frecency score of 101 (100+1). Frecency score is an internal score that is used by application-services that we can use to specify our threshold for when a visited site should be listed as a top site. Currently, a link with a single visit gets a score of 100, whereas a typed in URL gets a frecency score of 2000. Using a score 101 means it will ignore first-run/one-time/one-off visits to a page.

@topotropic
Copy link

Thanks @gabrielluong – we should be very deliberate and strict about what is automatically added to top sites and make sure it mirrors sites that people frequently visit on their mobile.

@vesta0
Copy link
Collaborator

vesta0 commented Oct 20, 2020

Thanks @gabrielluong I think this logic is better than what we have now. We should show a visited site as a top site only when it has a frecency score of 101 and ignore first-run/one-time/one-off visits.

@vesta0 vesta0 removed the needs:UX-investigation Issues where UX needs to define or scope a solution or determine feasibility label Oct 20, 2020
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Nov 4, 2020
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Nov 16, 2020
@gabrielluong gabrielluong added the pin Issues, features, improvements that are still valid label Jan 8, 2021
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 26, 2021
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 26, 2021
@gabrielluong
Copy link
Member Author

For testing, we want to ensure that any single page visits are no longer shown in the list of auto-populated top sites.

@abodea
Copy link
Member

abodea commented Jan 29, 2021

Verified as fixed on the latest Nightly build 1/29 with Google Pixel 4 XL (11).
Note that I accessed more than 15 webpages only once and they never appeared on the top sites with a clean profile.
When I accessed the pages for the second time they appeared.

@abodea abodea closed this as completed Jan 29, 2021
@sflorean sflorean added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Feb 3, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:qa:verified QA Verified Feature:Shortcuts Top Sites/Topsites on the Firefox home page pin Issues, features, improvements that are still valid
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants