Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #14302 - Skip one time pages visit from frecent top sites #16379

Closed
wants to merge 1 commit into from

Conversation

gabrielluong
Copy link
Member

Fixes #14302. Requires mozilla-mobile/android-components#8806

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@gabrielluong
Copy link
Member Author

@jonalmeida let's get this reviewed ahead of the next AC bump w/ breaking changes from mozilla-mobile/android-components#8806

Copy link
Contributor

@jonalmeida jonalmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@csadilek
Copy link
Contributor

Landing in #17649

@csadilek csadilek closed this Jan 26, 2021
@gabrielluong gabrielluong deleted the 14302 branch January 26, 2021 22:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-ac-bump PR that needs a AC bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate heuristics on how frequently visited top sites should appear
3 participants