Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Move webpush preflight check to validation #765

Closed
bbangert opened this issue Dec 23, 2016 · 0 comments
Closed

Move webpush preflight check to validation #765

bbangert opened this issue Dec 23, 2016 · 0 comments
Assignees
@bbangert
Labels
enhancement p1

Comments

@bbangert
Copy link
Member

bbangert commented Dec 23, 2016 •
edited
Loading

All the operations in the preflight check can be done during webpush validation, this would avoid more thread/async transferring.
@bbangert bbangert self-assigned this Jan 6, 2017
bbangert added a commit that referenced this issue Jan 6, 2017
@bbangert
feat: move preflight logic into webpush validation
5e353c0 
The preflight logic only applies to webpush, and is now included in
the validation up-front to avoid a return trip immediately to the
thread-pool.

Closes #765
@bbangert bbangert mentioned this issue Jan 6, 2017
Merged
bbangert added a commit that referenced this issue Jan 9, 2017
@bbangert
feat: move preflight logic into webpush validation (#772)
d963d18 
The preflight logic only applies to webpush, and is now included in
the validation up-front to avoid a return trip immediately to the
thread-pool.

Closes #765
@pjenvey pjenvey mentioned this issue Jan 11, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bbangert bbangert

Labels
enhancement p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bbangert