This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 128
React warning while loading shot page #2216
Labels
code quality
Not a bug, targeted for fixing in 2018
code
Code quality issue, that does not have any outward effect on the product
Milestone
Comments
ianb
added
code
Code quality issue, that does not have any outward effect on the product
and removed
defect
labels
Jan 10, 2018
chenba
added a commit
to chenba/screenshots
that referenced
this issue
Mar 14, 2018
Reopening this because setting the NODE_ICU_DATA env var is not working when deploying to dev. |
In other places we use a pattern like this to find the location of a library:
In the past I've found libraries aren't installed into entirely stable locations, and this helps. |
In this case, full-icu is not a js module to be required; the dir of a data file needs to supplied to node, either through env var or command line option. I have verified that the ICU data file is in the latest docker image and in the expected path. |
Looks like the cause is likely a node version mismatch. It's 8.2.0 during the build, but the docker image is running 8.10.0. This resulted in the wrong version of the ICU data being in the docker image. |
chenba
added a commit
to chenba/screenshots
that referenced
this issue
Mar 21, 2018
jaredhirsch
pushed a commit
that referenced
this issue
Mar 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
code quality
Not a bug, targeted for fixing in 2018
code
Code quality issue, that does not have any outward effect on the product
I'm seeing an error when I try and load the following shot page: https://pageshot.net/PNDTvTF1Q6jgffrZ/testpilot.firefox.com
The text was updated successfully, but these errors were encountered: