This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Match CircleCI node version to the Docker image's. #4250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredhirsch
reviewed
Mar 22, 2018
| @@ -7,6 +7,7 @@ COPY build/shared /app/build/shared | |||
| COPY node_modules /app/node_modules | |||
| COPY bin/_run-docker /app/bin/ | |||
| COPY build/screenshots.xpi /app/build/xpi/screenshots.xpi | |||
| ENV NODE_ICU_DATA="/app/node_modules/full-icu" | |||
There was a problem hiding this comment.
Yes. Still need this for node. The path was correct but the version of ICU data was incorrect last time around because CircleCI was using a different version of node than Docker. (The data is pulled down during a postinstall script into node_modules/full-icu; it's not dependent on the full-icu module version.) If I've left that env var along with the wrong version of ICU data, node won't run at all, so it was removed.
jaredhirsch
approved these changes
Mar 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2216's deployment issue