Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send dataLayer event for GA4 for newsletter subscriptions #13356

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

stephaniehobson
Copy link
Contributor

@stephaniehobson stephaniehobson commented Jul 7, 2023

One-line summary

Send a second dataLayer event when someone subscribes to a newsletter, to be processed by GA4.

Significant changes and points to review

Small code change but necessary because GA4 is going to be counting the number of subscriptions not the number of form submissions.

Issue / Bugzilla link

#13238
Fix #13348

Testing

  • find a few newsletters and look at the dataLayer in the console after you fill them out (use success@example.com to fill them out if you don't want a subscription 😉 )

@stephaniehobson stephaniehobson added P1 First level priority - Must have Needs Review Awaiting code review Review: XS Code review time: up to 30min labels Jul 7, 2023
Copy link
Contributor

@nathan-barrett nathan-barrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗞️ +

@nathan-barrett nathan-barrett merged commit 41927c9 into main Jul 12, 2023
@nathan-barrett nathan-barrett deleted the ga4-newsletter branch July 12, 2023 18:52
@stephaniehobson stephaniehobson removed the Needs Review Awaiting code review label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 First level priority - Must have Review: XS Code review time: up to 30min
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stopPropagation prevents GA4 from collecting newsletter submissions
2 participants