Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete data-cta-name usage #13932

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Remove obsolete data-cta-name usage #13932

merged 1 commit into from
Nov 27, 2023

Conversation

stephaniehobson
Copy link
Contributor

@stephaniehobson stephaniehobson commented Nov 24, 2023

One-line summary

As far as I can tell from GTM and UA, the data-cta-name value is not being recorded anywhere. Removing the unused data-attribute does not change how these CTAs are recorded in UA or GA4 and makes our docs less confusing.

Issue / Bugzilla link

#13238

@stephaniehobson stephaniehobson added Needs Review Awaiting code review Review: µ Code review time: 5 minutes or less Analytics 📈 labels Nov 24, 2023
@reemhamz reemhamz self-assigned this Nov 27, 2023
Copy link
Contributor

@reemhamz reemhamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ 🍪🥛

@reemhamz reemhamz merged commit dfb7481 into main Nov 27, 2023
5 checks passed
@reemhamz reemhamz deleted the ga4_links branch November 27, 2023 00:40
@stephaniehobson stephaniehobson removed the Needs Review Awaiting code review label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Analytics 📈 Review: µ Code review time: 5 minutes or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants