Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete data-cta-name usage #13932

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Remove obsolete data-cta-name usage #13932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bedrock/careers/templates/careers/benefits.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ <h1 class="c-text-hero-title">Benefits for real life</h1>
set us apart from other companies in our industry.</p>

<p class="c-careers-button-wrapper">
<a href="{{ url('careers.listings') }}" class="mzp-c-button mzp-t-dark" data-cta-type="button" data-cta-name="careers listings">See our open roles</a>
<a href="{{ url('careers.listings') }}" class="mzp-c-button mzp-t-dark" data-cta-type="button">See our open roles</a>
</p>
</div>
</div>
Expand Down
10 changes: 5 additions & 5 deletions bedrock/careers/templates/careers/home.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ <h2 class="c-careers-section-title">
</p>

<p class="c-careers-button-wrapper">
<a href="{{ url('careers.diversity') }}" data-cta-type="button" data-cta-name="careers diversity" class="mzp-c-button mzp-t-secondary">Read more</a>
<a href="{{ url('careers.diversity') }}" data-cta-type="button" class="mzp-c-button mzp-t-secondary">Read more</a>
</p>
</div>
</section>
Expand Down Expand Up @@ -264,7 +264,7 @@ <h2 class="c-careers-section-title">
</ul>

<p class="c-careers-button-wrapper">
<a href="{{ url('careers.benefits') }}" data-cta-type="button" data-cta-name="careers benefits" class="mzp-c-button mzp-t-secondary">Read more about our benefits</a>
<a href="{{ url('careers.benefits') }}" data-cta-type="button" class="mzp-c-button mzp-t-secondary">Read more about our benefits</a>
</p>
</div>
</section>
Expand All @@ -274,7 +274,7 @@ <h2 class="c-careers-section-title">
<div class="c-mozillians-content">
<h2>See yourself on one of our teams?</h2>
<p class="c-careers-button-wrapper">
<a href="{{ url('careers.listings') }}" data-cta-type="button" data-cta-name="careers listings" class="mzp-c-button mzp-t-dark">Find your role</a>
<a href="{{ url('careers.listings') }}" data-cta-type="button" class="mzp-c-button mzp-t-dark">Find your role</a>
</p>
</div>
</section>
Expand Down Expand Up @@ -377,7 +377,7 @@ <h2 class="c-careers-section-title">
</ul>

<p class="c-careers-button-wrapper">
<a href="{{ url('careers.teams') }}" data-cta-type="button" data-cta-name="careers teams" class="mzp-c-button mzp-t-secondary">View all teams</a>
<a href="{{ url('careers.teams') }}" data-cta-type="button" class="mzp-c-button mzp-t-secondary">View all teams</a>
</p>
</div>
</section>
Expand All @@ -400,7 +400,7 @@ <h2 class="c-careers-section-title">
</div>

<p class="c-careers-button-wrapper">
<a href="{{ url('careers.locations') }}" data-cta-type="button" data-cta-name="careers locations" class="mzp-c-button mzp-t-secondary">Read more about the future of work at Mozilla</a>
<a href="{{ url('careers.locations') }}" data-cta-type="button" class="mzp-c-button mzp-t-secondary">Read more about the future of work at Mozilla</a>
</p>
</div>
</section>
Expand Down
6 changes: 3 additions & 3 deletions bedrock/careers/templates/careers/locations.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ <h1 class="c-text-hero-title">We’ll meet you where you are — office optional
choose where they do it.</p>

<div class="c-careers-button-wrapper">
<a href="https://blog.mozilla.org/careers/future-of-work-at-mozilla/" class="mzp-c-button mzp-t-dark" data-cta-type="button" data-cta-name="how we work blogpost">Read more about how we work</a>
<a href="https://blog.mozilla.org/careers/future-of-work-at-mozilla/" class="mzp-c-button mzp-t-dark" data-cta-type="button">Read more about how we work</a>
</div>
</div>
</div>
Expand Down Expand Up @@ -49,15 +49,15 @@ <h2 class="c-careers-section-title">

<ul class="c-careers-locations-list">
<li>
<a href="{{ url('mozorg.contact.spaces.berlin') }}" data-cta-type="button" data-cta-name="Berlin office">
<a href="{{ url('mozorg.contact.spaces.berlin') }}" data-cta-type="button">
<div class="c-careers-locations-image-wrapper">
<img src="{{ static('img/careers/locations/mozilla-berlin.png') }}" alt="" width="200" height="200">
</div>
Berlin
</a>
</li>
<li>
<a href="{{ url('mozorg.contact.spaces.toronto') }}" data-cta-type="button" data-cta-name="Toronto office">
<a href="{{ url('mozorg.contact.spaces.toronto') }}" data-cta-type="button">
<div class="c-careers-locations-image-wrapper">
<img src="{{ static('img/careers/locations/mozilla-toronto.png') }}" alt="" width="200" height="200">
</div>
Expand Down
2 changes: 1 addition & 1 deletion bedrock/careers/templates/careers/teams.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ <h1 class="c-text-hero-title">Meet Mozilla’s teams</h1>
builders and creators working together to keep the internet open and
accessible to all.</p>
<div class="c-careers-button-wrapper">
<a href="{{ url('careers.listings') }}" class="mzp-c-button mzp-t-dark" data-cta-type="button" data-cta-name="careers listings">See our open roles</a>
<a href="{{ url('careers.listings') }}" class="mzp-c-button mzp-t-dark" data-cta-type="button">See our open roles</a>
</div>
</div>
</div>
Expand Down
12 changes: 6 additions & 6 deletions bedrock/firefox/templates/firefox/browsers/compare/brave.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,8 @@ <h2>{{ ftl('compare-shared-security-and-privacy-strong') }}</h2>
</tbody>
</table>

<p>{{ ftl('compare-brave-the-brave-browser-like-so', opera='href="%s" data-cta-type="link" data-cta-name="Opera"'|safe|format(url('firefox.browsers.compare.opera')),
edge='href="%s" data-cta-type="link" data-cta-name="Edge"'|safe|format(url('firefox.browsers.compare.edge'))) }}</p>
<p>{{ ftl('compare-brave-the-brave-browser-like-so', opera='href="%s" data-cta-type="link"'|safe|format(url('firefox.browsers.compare.opera')),
edge='href="%s" data-cta-type="link"'|safe|format(url('firefox.browsers.compare.edge'))) }}</p>

<p>{{ ftl('compare-brave-brave-differentiates-itself') }}</p>

Expand All @@ -102,9 +102,9 @@ <h2>{{ ftl('compare-shared-security-and-privacy-strong') }}</h2>

<p>{{ ftl('compare-brave-on-the-other-side-of-the-coin', attrs='href="https://addons.mozilla.org/firefox/addon/ublock-origin/" rel="external noopener" data-cta-text="uBlock Origin" data-cta-type="link"'|safe) }}</p>

<p>{{ ftl('compare-brave-there-are-a-few-of-braves', lockwise='href="%s" data-cta-type="link" data-cta-name="password manager"'|safe|format(url('firefox.features.password-manager')),
<p>{{ ftl('compare-brave-there-are-a-few-of-braves', lockwise='href="%s" data-cta-type="link"'|safe|format(url('firefox.features.password-manager')),
extension='href="https://addons.mozilla.org/addon/https-everywhere/" rel="external noopener" data-cta-text="HTTPS Everywhere" data-cta-type="link"'|safe,
privacy='href="%s" data-cta-type="link" data-cta-name="Privacy Report"'|safe|format(url('firefox.privacy.products'))) }}</p>
privacy='href="%s" data-cta-type="link"'|safe|format(url('firefox.privacy.products'))) }}</p>

<p>{{ ftl('compare-brave-the-bottom-line-is-that-even') }}</p>

Expand Down Expand Up @@ -241,7 +241,7 @@ <h2>{{ ftl('compare-shared-portability-strong') }}</h2>
<p>
{{ ftl('compare-brave-the-firefox-browser-also-gives-v3',
fallback='compare-brave-the-firefox-browser-also-gives',
accounts='href="%s" data-cta-type="link" data-cta-name="Firefox Account"'|safe|format(url('firefox.accounts')),
accounts='href="%s" data-cta-type="link"'|safe|format(url('firefox.accounts')),
monitor='href="https://monitor.firefox.com/" rel="external noopener" data-cta-text="Monitor" data-cta-type="link"'|safe,
breaches='href="https://monitor.firefox.com/breaches" rel="external noopener" data-cta-text="Data breaches" data-cta-type="link"'|safe
) }}
Expand All @@ -250,7 +250,7 @@ <h2>{{ ftl('compare-shared-portability-strong') }}</h2>
<p>
{{ ftl('compare-brave-the-firefox-browser-also-gives-v2',
fallback='compare-brave-the-firefox-browser-also-gives',
accounts='href="%s" data-cta-type="link" data-cta-name="Firefox Account"'|safe|format(url('firefox.accounts')),
accounts='href="%s" data-cta-type="link"'|safe|format(url('firefox.accounts')),
monitor='href="https://monitor.firefox.com/" rel="external noopener" data-cta-text="Monitor" data-cta-type="link"'|safe,
breaches='href="https://monitor.firefox.com/breaches" rel="external noopener" data-cta-text="Data breaches" data-cta-type="link"'|safe
) }}
Expand Down
2 changes: 1 addition & 1 deletion bedrock/firefox/templates/firefox/browsers/compare/chrome.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ <h2>{{ ftl('compare-shared-security-and-privacy-strong') }}</h2>
{% endif %}
</p>

<p>{{ ftl('compare-chrome-weve-also-recently-restated-v2', attrs='href="%s" data-cta-type="link" data-cta-name="Privacy Notice"'|safe|format(url('privacy.notices.firefox'))) }}</p>
<p>{{ ftl('compare-chrome-weve-also-recently-restated-v2', attrs='href="%s" data-cta-type="link"'|safe|format(url('privacy.notices.firefox'))) }}</p>

<p>{{ ftl('compare-chrome-google-chrome-is-by-all-accounts') }}</p>

Expand Down
8 changes: 4 additions & 4 deletions bedrock/firefox/templates/firefox/browsers/compare/edge.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ <h2>{{ ftl('compare-shared-security-and-privacy-strong') }}</h2>

<p>{{ ftl('compare-edge-edge-is-integrated-into-the') }}</p>

<p>{{ ftl('compare-edge-at-firefox-we-pride-ourselves', fallback='compare-edge-at-firefox-our-privacy-fallback', attrs='href="%s" data-cta-type="link" data-cta-name="privacy policy"'|safe|format(url('privacy.notices.firefox'))) }}</p>
<p>{{ ftl('compare-edge-at-firefox-we-pride-ourselves', fallback='compare-edge-at-firefox-our-privacy-fallback', attrs='href="%s" data-cta-type="link"'|safe|format(url('privacy.notices.firefox'))) }}</p>

<img src="{{ static('img/firefox/compare/compare-privacy-eyes.svg') }}" alt="" height="217" width="320" class="compare-details-image">

Expand Down Expand Up @@ -180,7 +180,7 @@ <h2>{{ ftl('compare-shared-utility-strong') }}</h2>

<p>{{ ftl('compare-edge-edge-has-some-nice-ui-features') }}</p>

<p>{{ ftl('compare-edge-firefox-features-a-scrolling', attrs='href="%s" data-cta-type="link" data-cta-name="Pocket feature"'|safe|format(url('firefox.pocket'))) }}</p>
<p>{{ ftl('compare-edge-firefox-features-a-scrolling', attrs='href="%s" data-cta-type="link"'|safe|format(url('firefox.pocket'))) }}</p>

<p>{{ ftl('compare-edge-firefox-and-edge-both-offer', fallback='compare-edge-firefox-and-edge-both-offer-fallback') }}</p>

Expand Down Expand Up @@ -236,7 +236,7 @@ <h2>{{ ftl('compare-shared-portability-strong') }}</h2>

<p>{{ ftl('compare-edge-with-internet-explorer-microsoft', fallback='compare-edge-with-internet-explorer-fallback') }}</p>

<p>{{ ftl('compare-edge-firefox-has-been-available', attrs='href="%s" data-cta-type="link" data-cta-name="free account"'|safe|format(url('firefox.accounts'))) }}</p>
<p>{{ ftl('compare-edge-firefox-has-been-available', attrs='href="%s" data-cta-type="link"'|safe|format(url('firefox.accounts'))) }}</p>

<p>{{ ftl('compare-edge-edge-also-allows-you-to-connect', fallback='compare-edge-edge-also-allows-you-to-fallback') }}</p>

Expand All @@ -249,7 +249,7 @@ <h2>{{ ftl('compare-shared-portability-strong') }}</h2>
<h2>{{ ftl('compare-shared-overall-assessment') }}</h2>
</header>

<p>{{ ftl('compare-edge-aside-from-sucking-up-a-lot', attrs='href="%s" data-cta-type="link" data-cta-name="Mozilla"'|safe|format(url('mozorg.home'))) }}</p>
<p>{{ ftl('compare-edge-aside-from-sucking-up-a-lot', attrs='href="%s" data-cta-type="link"'|safe|format(url('mozorg.home'))) }}</p>

<p>{{ ftl('compare-edge-the-bottom-line-is-that-while') }}</p>

Expand Down
12 changes: 6 additions & 6 deletions bedrock/firefox/templates/firefox/browsers/compare/ie.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,14 +93,14 @@ <h2>{{ ftl('compare-shared-security-and-privacy-strong') }}</h2>
</tbody>
</table>

<p>{{ ftl('compare-ie-if-you-havent-moved-on-from-using', attrs='href="https://www.telegraph.co.uk/technology/2019/02/08/stop-using-internet-explorer-warns-microsofts-security-chief/" rel="external noopener" data-cta-type="link" data-cta-name="Microsoft security chief warned"'|safe) }}</p>
<p>{{ ftl('compare-ie-if-you-havent-moved-on-from-using', attrs='href="https://www.telegraph.co.uk/technology/2019/02/08/stop-using-internet-explorer-warns-microsofts-security-chief/" rel="external noopener" data-cta-type="link"'|safe) }}</p>

<p>{{ ftl('compare-ie-microsoft-is-no-longer-supporting') }}</p>

<img src="{{ static('img/firefox/compare/compare-privacy-locks.svg') }}" alt="" height="217" width="320" class="compare-details-image">

<p>{{ ftl('compare-ie-so-whats-the-solution-if-your', fallback='compare-ie-so-whats-the-solution-if-your-fallback', lockwise='href="%s" data-cta-type="link" data-cta-name="password manager"'|safe|format(url('firefox.features.password-manager')),
privacy='href="%s" data-cta-type="link" data-cta-name="privacy policy"'|safe|format(url('privacy.notices.firefox'))) }}</p>
<p>{{ ftl('compare-ie-so-whats-the-solution-if-your', fallback='compare-ie-so-whats-the-solution-if-your-fallback', lockwise='href="%s" data-cta-type="link"'|safe|format(url('firefox.features.password-manager')),
privacy='href="%s" data-cta-type="link"'|safe|format(url('privacy.notices.firefox'))) }}</p>

{% include '/firefox/browsers/compare/includes/download-menu-list.html' %}

Expand Down Expand Up @@ -178,8 +178,8 @@ <h2>{{ ftl('compare-shared-utility-strong') }}</h2>
<p>{{ ftl('compare-ie-really-the-only-reasons-to-use') }}</p>

<p>
{{ ftl('compare-ie-on-the-other-end-of-the-spectrum', fallback='compare-ie-on-the-other-end-of-the-spectrum-fallback', pocket='href="%s" data-cta-type="link" data-cta-name="Pocket"'|safe|format(url('firefox.pocket')),
products='href="%s" data-cta-type="link" data-cta-name="our other Firefox products"'|safe|format(url('firefox'))) }}
{{ ftl('compare-ie-on-the-other-end-of-the-spectrum', fallback='compare-ie-on-the-other-end-of-the-spectrum-fallback', pocket='href="%s" data-cta-type="link"'|safe|format(url('firefox.pocket')),
products='href="%s" data-cta-type="link"'|safe|format(url('firefox'))) }}
</p>

{% include '/firefox/browsers/compare/includes/download-menu-list.html' %}
Expand Down Expand Up @@ -245,7 +245,7 @@ <h2>{{ ftl('compare-shared-overall-assessment') }}</h2>

<p>
{# Download link should be locale neutral. See issue #7982 #}
{{ ftl('compare-ie-our-opinion-is-just-to-go-with', attrs='href="/firefox/download/thanks/" data-cta-type="link" data-cta-name="download Firefox"'|safe) }}
{{ ftl('compare-ie-our-opinion-is-just-to-go-with', attrs='href="/firefox/download/thanks/" data-cta-type="link"'|safe) }}
</p>

<div class="compare-content compare-version-disclaimer">
Expand Down
2 changes: 1 addition & 1 deletion bedrock/firefox/templates/firefox/browsers/compare/opera.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ <h2>{{ ftl('compare-shared-security-and-privacy-strong') }}</h2>

<p>{{ ftl('compare-opera-operas-privacy-policy-lacks', fallback='compare-opera-operas-privacy-policy-lacks-fallback') }}</p>

<p>{{ ftl('compare-opera-firefoxs-privacy-policy-is', attrs = 'href="%s" data-cta-type="link" data-cta-name="privacy policy"'|safe|format(url('privacy.notices.firefox'))) }}</p>
<p>{{ ftl('compare-opera-firefoxs-privacy-policy-is', attrs = 'href="%s" data-cta-type="link"'|safe|format(url('privacy.notices.firefox'))) }}</p>

<p>{{ ftl('compare-opera-as-far-as-actual-privacy-protections') }}</p>

Expand Down
4 changes: 2 additions & 2 deletions bedrock/firefox/templates/firefox/browsers/compare/safari.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ <h2>{{ ftl('compare-shared-security-and-privacy-strong') }}</h2>

<p>{{ ftl('compare-safari-our-private-browsing-mode', attrs='href="https://addons.mozilla.org/firefox/addon/facebook-container/" rel="external noopener" data-cta-text="Facebook Container" data-cta-type="link"'|safe) }}</p>

<p>{{ ftl('compare-safari-as-far-as-security-goes-firefox', lockwise='href="%s" data-cta-type="link" data-cta-name="password manager"'|safe|format(url('firefox.features.password-manager')), monitor='href="https://monitor.firefox.com/" rel="external noopener" data-cta-text="Monitor" data-cta-type="link"'|safe) }}</p>
<p>{{ ftl('compare-safari-as-far-as-security-goes-firefox', lockwise='href="%s" data-cta-type="link"'|safe|format(url('firefox.features.password-manager')), monitor='href="https://monitor.firefox.com/" rel="external noopener" data-cta-text="Monitor" data-cta-type="link"'|safe) }}</p>

<p>{{ ftl('compare-safari-if-you-choose-to-use-safari') }}</p>

Expand Down Expand Up @@ -238,7 +238,7 @@ <h2>{{ ftl('compare-shared-portability-strong') }}</h2>

<p>{{ ftl('compare-safari-firefox-and-safari-both-provide') }}</p>

<p>{{ ftl('compare-safari-firefox-also-offers-a-similar-updated-v3', fallback='compare-safari-firefox-also-offers-a-similar-updated', attrs = 'href="%s" data-cta-type="link" data-cta-name="Mozilla account"'|safe|format(url('firefox.accounts'))) }}</p>
<p>{{ ftl('compare-safari-firefox-also-offers-a-similar-updated-v3', fallback='compare-safari-firefox-also-offers-a-similar-updated', attrs = 'href="%s" data-cta-type="link"'|safe|format(url('firefox.accounts'))) }}</p>

<p>{{ ftl('compare-safari-the-firefox-app-for-ios-and', ios='href="%s" rel="external noopener" data-cta-text="iOS" data-cta-type="link"'|safe|format(app_store_url('firefox')),
android='href="%s" rel="external noopener" data-cta-text="Android" data-cta-type="link"'|safe|format(play_store_url('firefox'))) }}</p>
Expand Down
Loading