Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vanity URL redirect for Nothing Personal page [fix #14944] #14945

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

craigcook
Copy link
Member

One-line summary

Adds a redirect from /nothingpersonal/ (or /nothing-personal/) to /firefox/nothing-personal/. This makes a URL easier to speak aloud in audio ads.

Issue / Bugzilla link

#14944

Testing

http://localhost:8000/nothingpersonal should redirect to http://localhost:8000/firefox/nothing-personal/

@craigcook craigcook added Needs Review Awaiting code review Review: µ Code review time: 5 minutes or less labels Jul 31, 2024
@stephaniehobson stephaniehobson self-assigned this Jul 31, 2024
@craigcook craigcook force-pushed the 14944-nothing-personal-redirect branch from 6c802ee to 6f3e77f Compare July 31, 2024 21:52
Copy link
Contributor

@stephaniehobson stephaniehobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R+

@craigcook craigcook merged commit 6ec4adb into mozilla:main Jul 31, 2024
5 checks passed
@craigcook craigcook deleted the 14944-nothing-personal-redirect branch July 31, 2024 22:04
@stephaniehobson stephaniehobson removed the Needs Review Awaiting code review label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: µ Code review time: 5 minutes or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants