Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh: restore large icons for about page #15684

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

craigcook
Copy link
Member

One-line summary

#15651 merged before I could replace the about page icons in a different location. Marking this as P1 since it fixes those missing images so it needs to merge before our next prod push.

I'll follow up later with a full set of the large icons in both black and white, but for now we just need these four.

Testing

http://localhost:8000/en-US/about/

@craigcook craigcook added P1 First level priority - Must have Needs Review Awaiting code review Review: µ Code review time: 5 minutes or less labels Dec 5, 2024
@craigcook craigcook requested a review from a team as a code owner December 5, 2024 02:40
@stephaniehobson
Copy link
Contributor

Bah, they worked when I tested locally. shakes fist at caching

Copy link
Contributor

@stephaniehobson stephaniehobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R+ 🔔

@stephaniehobson stephaniehobson merged commit 495efdd into mozilla:main Dec 5, 2024
5 checks passed
@craigcook craigcook deleted the m24-big-icons branch December 6, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review Awaiting code review P1 First level priority - Must have Review: µ Code review time: 5 minutes or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants