Refresh: optimize images, delete some cruft #15651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigcook
added
Needs Review
stephaniehobson
requested changes
Dec 4, 2024
craigcook
force-pushed
the
m24-tinify-images
branch
from
33ad77f to
811d1e1
Compare
craigcook
force-pushed
the
m24-tinify-images
branch
from
811d1e1 to
4019ac4
Compare
Filed #15684 to restore those icons, now in an |
janbrasna
reviewed
Dec 9, 2024
There was a problem hiding this comment.
Not sure where the file name comes from… but it's missing a dash — so maybe that might be renamed from protocolwhite to protocol-white before any widespread use?
EDIT: renaming that in #15719
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Just ran images through tinypng. Most had already been optimized but almost everything got another 5-10% savings on a second run without any apparent quality loss.
Ran the icons through SVGO, which only a few really needed but almost all still shaved a few bytes... except a few gained a few bytes from adding line breaks.
Deleted a few old images that have been replaced. I figure we should keep the
todo-*placeholders for now because they'll be useful on future pages.Issue / Bugzilla link
#15416
Testing
Just make sure I didn't delete anything still in use, and that images haven't degraded in quality.