Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newsletter dropdown caret hover #15719

Merged
merged 5 commits into from
Dec 12, 2024

Conversation

janbrasna
Copy link
Contributor

@janbrasna janbrasna commented Dec 12, 2024

One-line summary

Fixes select dropdown affordance blending in with background when active.

Significant changes and points to review

  1. This refactors the caret to use m24-small icons.
  2. (Also cleans up any old assets no longer used.)
  3. Adds RTL support.
  4. Adds hover state.
  5. Improves alignment for more type/size resilience.

Issue / Bugzilla link

Fixes #15716

Testing

http://localhost:8000/en-US/#colophon

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.06%. Comparing base (f47a17d) to head (a03eefa).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15719   +/-   ##
=======================================
  Coverage   79.06%   79.06%           
=======================================
  Files         160      160           
  Lines        8355     8355           
=======================================
  Hits         6606     6606           
  Misses       1749     1749           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janbrasna janbrasna marked this pull request as ready for review December 12, 2024 12:49
@janbrasna janbrasna requested a review from a team as a code owner December 12, 2024 12:49
@wen-2018 wen-2018 self-assigned this Dec 12, 2024
Copy link
Collaborator

@wen-2018 wen-2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! r+

@wen-2018 wen-2018 merged commit d667a96 into mozilla:main Dec 12, 2024
5 checks passed
@janbrasna janbrasna deleted the fix/select-hover-caret branch December 12, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown menu arrow disapears on hover
2 participants