Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EOY Donate Banner (Fix #15711) #15720

Merged
merged 2 commits into from
Dec 17, 2024
Merged

EOY Donate Banner (Fix #15711) #15720

merged 2 commits into from
Dec 17, 2024

Conversation

stephaniehobson
Copy link
Contributor

@stephaniehobson stephaniehobson commented Dec 12, 2024

One-line summary

Update fundraising banner for EOY campaign.

  • I tried to use an AI to write some of this code and it failed miserably so I didn't use the output at all.

Significant changes and points to review

  • 3 variants in 8 languages
  • a DNT/GCP compliant fallback

Issue / Bugzilla link

Fix #15711

Testing

  • disabling the switch fundraising-banner-2024eoy removes the banner and brings the pencil banner back
  • disabling the switch show-pencil-banner hides the pencil banner
  • the fundraising banner can be enabled with the pencil banner disabled
  • experiment does not load with GCP enabled (test in Brave browser, it's enabled by default)

Has banner:

Does not have banner:

http://localhost:8000/ms/

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.06%. Comparing base (0fa03eb) to head (d94b126).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15720   +/-   ##
=======================================
  Coverage   79.06%   79.06%           
=======================================
  Files         160      160           
  Lines        8355     8355           
=======================================
  Hits         6606     6606           
  Misses       1749     1749           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephaniehobson stephaniehobson marked this pull request as ready for review December 12, 2024 19:26
@stephaniehobson stephaniehobson requested a review from a team as a code owner December 12, 2024 19:26
@stephaniehobson stephaniehobson added P1 First level priority - Must have Needs Review Awaiting code review Review: S Code review time: 30 mins to 1 hour Frontend HTML, CSS, JS... client side stuff labels Dec 12, 2024
@craigcook craigcook self-assigned this Dec 16, 2024
Copy link
Member

@craigcook craigcook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor nitpick: the headline sometimes runs into the close button at some mobile sizes, but it's a bit of an edge case. Could add some padding to the headline to preserve space on mobile.

image

r+wc 🍌

@craigcook craigcook removed the Needs Review Awaiting code review label Dec 17, 2024
@stephaniehobson stephaniehobson merged commit 6557524 into main Dec 17, 2024
5 checks passed
@stephaniehobson stephaniehobson deleted the 2024-eoy branch December 17, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend HTML, CSS, JS... client side stuff P1 First level priority - Must have Review: S Code review time: 30 mins to 1 hour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EOY Donate Banner
3 participants