Merge pull request #598 from anforowicz/clippy-cleanup

Clean up `rustc` and `clippy` warnings.

src/network.rs

@@ -28,7 +28,10 @@ use crate::{
 /// Wrapper for the pair of a `reqwest::Response` and the `SemaphorePermit` used
 /// to limit concurrent connections, with a test-only variant for mocking.
 enum Response<'a> {
-    Real(reqwest::Response, tokio::sync::SemaphorePermit<'a>),
+    Real(
+        reqwest::Response,
+        #[allow(unused)] tokio::sync::SemaphorePermit<'a>,
+    ),
     #[cfg(test)]
     Mock(Option<Bytes>),
 }

src/serialization.rs

@@ -518,7 +518,7 @@ pub mod spanned {
     thread_local! {
         /// Hack to work around `toml::Spanned` failing to be deserialized when
         /// used with the `toml::Value` deserializer.
-        pub(super) static DISABLE_SPANNED_DESERIALIZATION: Cell<bool> = Cell::new(false);
+        pub(super) static DISABLE_SPANNED_DESERIALIZATION: Cell<bool> = const { Cell::new(false) };
     }
 
     /// A spanned value, indicating the range at which it is defined in the source.

src/storage.rs

@@ -2828,6 +2828,7 @@ fn create_unpack_lock(unpack_dir: &Path) -> Result<(), io::Error> {
     // which may have been extracted from the package.
     let mut ok = OpenOptions::new()
         .create(true)
+        .truncate(true)
         .read(true)
         .write(true)
         .open(lockfile)?;