Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up rustc and clippy warnings. #598

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Conversation

anforowicz
Copy link
Contributor

@anforowicz
Copy link
Contributor Author

AFAIU tokio::sync::SemaphorePermit is not supposed to be read:

  • We don't need to execute it's forget or merge methods
  • We do care about the implicitly executed drop method

Not sure if some additional follow-up may be needed here. I wondered about reporting this at https://github.com/rust-lang/rust/issues/new, but I guess not all drop methods count as using a field (Vec's drop probably wouldn't count). So I guess just allowing "dead code" here is a reasonable workaround.

@anforowicz
Copy link
Contributor Author

Ooops... I didn't run cargo fmt... This should be fixed now in 008636f

src/network.rs Outdated Show resolved Hide resolved
@mystor mystor merged commit 9bf5bbe into mozilla:main Apr 1, 2024
5 of 8 checks passed
@anforowicz anforowicz deleted the clippy-cleanup branch April 1, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants