Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fxa-settings): update string id on updated string #12790

Merged
merged 1 commit into from
May 6, 2022

Conversation

millmason
Copy link
Contributor

@millmason millmason commented May 6, 2022

Because

  • I forgot to update the string id on a string which I changed, so it needs an updated ID to alert localizers to the change.

This pull request

  • updates the string id on the changed string.

Issue that this pull request solves

Closes: #12787

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

N/a (no visible change)

Other information (Optional)

Any other information that is important to this pull request.

@millmason millmason requested a review from a team as a code owner May 6, 2022 16:16
@millmason millmason merged commit b4a3ccd into main May 6, 2022
@millmason millmason deleted the fxa-5049-update-string-id branch May 6, 2022 17:18
@millmason millmason restored the fxa-5049-update-string-id branch May 11, 2022 16:40
@millmason millmason deleted the fxa-5049-update-string-id branch July 12, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need a new string ID for new string
2 participants