fix(fxa-settings) remove static list of features + pocket copy [DO NOT MERGE] #12849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… warning fix(fxa-settings) Add change to l10n files, remove unused constants fix(fxa-settings) remove outdated Pocket reference from checklist fix(fxa-settings): update string id on updated string
LZoog
reviewed
May 13, 2022
Comment on lines
-8
to
-9
| export const VPNLink = 'https://vpn.mozilla.org/'; | ||
| export const MonitorLink = 'https://monitor.firefox.com/'; |
There was a problem hiding this comment.
I think we actually use these in ConnectedServices as well as our Bento menu without referencing these consts. Could be worth leaving these, and changing those references to this const.
There was a problem hiding this comment.
git grep -nE "(monitor.firefox.com|vpn.mozilla.org)" | cat
packages/functional-tests/tests/signin/relyingParties.spec.ts:100: await page.goto('https://monitor.firefox.com');
packages/functional-tests/tests/signin/relyingParties.spec.ts:106: expect(page.url()).toMatch('https://monitor.firefox.com/user/dashboard');
packages/fxa-auth-server/test/local/payments/fixtures/stripe/subscription_pmi_expanded_incomplete_cvc_fail.json:47: "downloadURL": "https://vpn.mozilla.org/vpn/download?utm_medium=email&utm_source=email&utm_campaign=subscription-download",
packages/fxa-auth-server/test/local/payments/fixtures/stripe/subscription_pmi_expanded_incomplete_cvc_fail.json:67: "downloadURL": "https://vpn.mozilla.org/vpn/download?utm_medium=email&utm_source=email&utm_campaign=subscription-download",
packages/fxa-auth-server/test/local/payments/fixtures/stripe/subscription_pmi_expanded_incomplete_cvc_fail.json:170: "downloadURL": "https://vpn.mozilla.org/vpn/download?utm_medium=email&utm_source=email&utm_campaign=subscription-download",
packages/fxa-auth-server/test/local/payments/fixtures/stripe/subscription_pmi_expanded_incomplete_cvc_fail.json:190: "downloadURL": "https://vpn.mozilla.org/vpn/download?utm_medium=email&utm_source=email&utm_campaign=subscription-download",
packages/fxa-auth-server/test/local/payments/fixtures/stripe/subscription_pmi_expanded_incomplete_cvc_fail.json:481: "downloadURL": "https://vpn.mozilla.org/vpn/download?utm_medium=email&utm_source=email&utm_campaign=subscription-download",
packages/fxa-settings/src/components/BentoMenu/index.tsx:71: href="https://monitor.firefox.com"
packages/fxa-settings/src/components/BentoMenu/index.tsx:125: href="https://vpn.mozilla.org/?utm_source=accounts.firefox.com&utm_medium=referral&utm_campaign=fxa-settings&utm_content=bento-promo"
packages/fxa-settings/src/components/ConnectedServices/Service.tsx:50: serviceLink = 'https://monitor.firefox.com/';
packages/fxa-settings/src/components/ConnectedServices/index.test.tsx:141: 'https://monitor.firefox.com/'
|
The schedule for this is undetermined but a ways out. Let's close this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(fxa-settings) Add change to l10n files, remove unused constants
fix(fxa-settings) remove outdated Pocket reference from checklist
fix(fxa-settings): update string id on updated string
Because
This pull request
Issue that this pull request solves
Closes: #11578
Checklist
Put an
xin the boxes that applyOther information (Optional)
Original PRs: #12790,
#12731