Skip to content
This repository has been archived by the owner on Dec 1, 2017. It is now read-only.

Isolate state errors on the client-side #246

Open
gideonthomas opened this issue Aug 11, 2014 · 1 comment
Open

Isolate state errors on the client-side #246

gideonthomas opened this issue Aug 11, 2014 · 1 comment

Comments

@gideonthomas
Copy link
Contributor

Our client-side code mirrors a number of aspects of the server code.

One instance of this is in our message handler's when we 'check the message type/name' and 'check that the client is in the right state'. These two checks should be separated since if one of them fails, the client gets a generic error message which makes it hard to decipher whether an incorrect message was received or if its in the wrong state.

To fix this, we should first check the message, and then in each specific message handler, check the state before doing anything. If it is in the wrong state, we should throw a 'state' error as opposed to a generic error.

@gideonthomas
Copy link
Contributor Author

Instead of the above approach, since states are almost irrelevant in the per-file syncing case, client-side logging will be used to log errors.

@gideonthomas gideonthomas added this to the Per-file Syncing Part 2 milestone Jan 9, 2015
gideonthomas added a commit to gideonthomas/makedrive that referenced this issue May 27, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant