Skip to content
This repository has been archived by the owner on Dec 1, 2017. It is now read-only.

Rsync patch should use rmdir to remove deleted directories #427

Open
gideonthomas opened this issue Oct 15, 2014 · 4 comments
Open

Rsync patch should use rmdir to remove deleted directories #427

gideonthomas opened this issue Oct 15, 2014 · 4 comments
Labels
bug critical
Milestone
Per-file Syncing ...

Comments

@gideonthomas
Copy link
Contributor

I just pulled down from master with my latest commit being ecd52eb

But I have an rsync test failing...

  1) [Rsync Functional tests] should succeed syncing a directory that has been renamed:
     Uncaught Error: unlink not permitted on directories
      at new FilerError (/Users/gideonthomas/makedrive/node_modules/filer/src/errors.js:91:19)
      at check_if_node_is_directory (/Users/gideonthomas/makedrive/node_modules/filer/src/filesystem/implementation.js:1047:16)
      at Object._onImmediate (/Users/gideonthomas/makedrive/node_modules/filer/src/providers/memory.js:44:5)
      at processImmediate [as _immediateCallback] (timers.js:345:15)
@gideonthomas gideonthomas added this to the Everest milestone Oct 15, 2014
@gideonthomas
Copy link
Contributor Author

cc @humphd @alicoding

@gideonthomas
Copy link
Contributor Author

Yeah....I think the problem is because we updated filer which has a commit that does not allow unlinks on directories and we do that in rsync while removing nodes that were deleted on the server. The fix would be to check if it is a dir and use rmdir instead.

@gideonthomas gideonthomas changed the title Tests failing on master Rsync patch should use rmdir to remove deleted directories Oct 16, 2014
@gideonthomas
Copy link
Contributor Author

sigh so I have a fix for this but filer (filerjs/filer#308) needs to be fixed first

gideonthomas added a commit to gideonthomas/makedrive that referenced this issue Oct 16, 2014
@gideonthomas
Fix mozilla#427 - Rsync patch should use rmdir to remove deleted dire…
50c81a9 
…ctories
@gideonthomas
Copy link
Contributor Author

moving out of everest so that we can use @alicoding's branch with a filer fix on it that can circumvent this error temporarily

@gideonthomas gideonthomas reopened this Oct 24, 2014
@gideonthomas gideonthomas removed this from the Everest milestone Oct 24, 2014
@gideonthomas gideonthomas added this to the Per-file Syncing Part 2 milestone Jan 9, 2015
gideonthomas added a commit to gideonthomas/makedrive that referenced this issue May 27, 2015
@gideonthomas
Complete rewrite - Fix mozilla#470 mozilla#450 mozilla#427 mozilla#308 …
c28dc53 
…mozilla#246 and refactor tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug critical
Projects
None yet
Milestone
Per-file Syncing Part 2
Development

No branches or pull requests
1 participant
@gideonthomas