Add TOS and TTL information to Datagrams #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larseggert
requested review from
KershawChang and
martinthomson
as code owners
3 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1568 +/- ##
==========================================
- Coverage 87.60% 87.59% -0.02%
==========================================
Files 117 118 +1
Lines 38333 38464 +131
==========================================
+ Hits 33583 33693 +110
- Misses 4750 4771 +21 ☔ View full report in Codecov by Sentry. |
martinthomson
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
This is looking good.
I'm semi-serious about having a wrapper type for IpTos. You have a case where you set a tos argument to a value of the Ecn enum. But I think that you want a wrapper type (that trivially converts to u8) that has simple functions for converting from IpTosEcn and (IpTosDscp, IpTosEcn).
|
@martinthomson does the current version of this PR implement what you suggested? |
martinthomson
approved these changes
Jan 21, 2024
This part of the refactor of mozilla#1495. This doesn't include any ECN I/O or other logic, just adds the required fields to the datagram header.
I might back this back out if it is not the direction we want to go in, pending further discussion.
larseggert
force-pushed
the
feat-ecn-plumbing
branch
from
ab61221
to
d5dead7
Compare
mxinden
added a commit
to mxinden/neqo
that referenced
this pull request
Jun 25, 2024
mozilla#1568 introduced TTL information to datagrams. On the input path it would take the ttl information, but not act on it. On the output path it would set only "the default TTL on many OSes". https://github.com/mozilla/neqo/blob/66504908e5fa070a8a5fa67d8b5a201d2c9a5cc5/neqo-transport/src/path.rs#L576 This commit removes the ttl information from `Datagram`, thus reverting a subset of mozilla#1568. This is partially motivated by mozilla#1920, introducing `quinn-udp` as the IO library of choice, which does not support reading and writing TTL. See also discussion in mozilla#1920 (comment).
mxinden
added a commit
to mxinden/neqo
that referenced
this pull request
Jun 25, 2024
mozilla#1568 introduced TTL information to datagrams. On the input path it would take the ttl information, but not act on it. On the output path it would set only "the default TTL on many OSes". https://github.com/mozilla/neqo/blob/66504908e5fa070a8a5fa67d8b5a201d2c9a5cc5/neqo-transport/src/path.rs#L576 This commit removes the ttl information from `Datagram`, thus reverting a subset of mozilla#1568. This is partially motivated by mozilla#1920, introducing `quinn-udp` as the IO library of choice, which does not support reading and writing TTL. See also discussion in mozilla#1920 (comment).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 26, 2024
#1568 introduced TTL information to datagrams. On the input path it would take the ttl information, but not act on it. On the output path it would set only "the default TTL on many OSes". https://github.com/mozilla/neqo/blob/66504908e5fa070a8a5fa67d8b5a201d2c9a5cc5/neqo-transport/src/path.rs#L576 This commit removes the ttl information from `Datagram`, thus reverting a subset of #1568. This is partially motivated by #1920, introducing `quinn-udp` as the IO library of choice, which does not support reading and writing TTL. See also discussion in #1920 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This part of the refactor of #1495.
This doesn't include any ECN I/O or other logic, just adds the required fields to the datagram header.