Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(qns): implement v2 testcase #1570

Merged
merged 2 commits into from
Jan 21, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions neqo-client/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1018,6 +1018,7 @@ fn main() -> Res<()> {
args.use_old_http = true;
args.key_update = true;
}
"v2" => {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The v2 test also runs on HTTP/0.9. Do you need to set use_old_http here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, exactly right. Thank you @marten-seemann. See 61ed61e.

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting!

_ => exit(127),
}
}
Expand Down
11 changes: 7 additions & 4 deletions neqo-server/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -837,10 +837,12 @@ fn main() -> Result<(), io::Error> {

if let Some(testcase) = args.qns_test.as_ref() {
if args.quic_parameters.quic_version.is_empty() {
// Quic Interop Runner expects the server to support `Version1` only.
// Exceptions are testcases `versionnegotiation` and `v2`. Neither are
// supported by Neqo. Thus always set `Version1`.
args.quic_parameters.quic_version = vec![VersionArg(Version::Version1)];
// Quic Interop Runner expects the server to support `Version1`
// only. Exceptions are testcases `versionnegotiation` (not yet
// implemented) and `v2`.
if testcase != "v2" {
args.quic_parameters.quic_version = vec![VersionArg(Version::Version1)];
}
} else {
qwarn!("Both -V and --qns-test were set. Ignoring testcase specific versions.");
}
Expand Down Expand Up @@ -868,6 +870,7 @@ fn main() -> Result<(), io::Error> {
args.alpn = String::from(HQ_INTEROP);
args.retry = true;
}
"v2" => (),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here?

_ => exit(127),
}
}
Expand Down
Loading