feat(qns): implement v2 testcase #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for Quic Network Simulator `v2` testcase. In `v2` testcase, don't restrict the server to `Version::Version1`, thus allowing the server to upgrade incoming `Version::Version1` connection to compatible `Version::Version2` connection. See also [Quic Network Simulator `v2` testcase implementation]( https://github.com/quic-interop/quic-interop-runner/blob/ca27dcb5272a82d994337ae3d14533c318d81b76/testcases.py#L1460-L1545).
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1570 +/- ##
==========================================
- Coverage 87.60% 87.59% -0.02%
==========================================
Files 117 117
Lines 38335 38256 -79
==========================================
- Hits 33584 33510 -74
+ Misses 4751 4746 -5 ☔ View full report in Codecov by Sentry. |
neqo-client/src/main.rs
Outdated
| @@ -1018,6 +1018,7 @@ fn main() -> Res<()> { | |||
| args.use_old_http = true; | |||
| args.key_update = true; | |||
| } | |||
| "v2" => {} | |||
There was a problem hiding this comment.
The v2 test also runs on HTTP/0.9. Do you need to set use_old_http here?
There was a problem hiding this comment.
Yes, exactly right. Thank you @marten-seemann. See 61ed61e.
neqo-server/src/main.rs
Outdated
| @@ -868,6 +870,7 @@ fn main() -> Result<(), io::Error> { | |||
| args.alpn = String::from(HQ_INTEROP); | |||
| args.retry = true; | |||
| } | |||
| "v2" => (), | |||
marten-seemann
approved these changes
Jan 19, 2024
martinthomson
approved these changes
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Quic Network Simulator
v2testcase.In
v2testcase, don't restrict the server toVersion::Version1, thus allowing the server to upgrade incomingVersion::Version1connection to compatibleVersion::Version2connection.See also Quic Network Simulator
v2testcase implementation.//CC @marten-seemann
Follow-up to #1563.
Related to quic-interop/quic-interop-runner#344 and #1552.