Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider building and pushing Interop Runner Docker image in CI #1552

Closed
marten-seemann opened this issue Jan 14, 2024 · 3 comments · Fixed by #1554
Closed

consider building and pushing Interop Runner Docker image in CI #1552

marten-seemann opened this issue Jan 14, 2024 · 3 comments · Fixed by #1554

Comments

@marten-seemann
Copy link
Contributor

I noticed that the neqo interop runner image is now 3 years (!) old: https://hub.docker.com/r/neqoquic/neqo-qns/tags. I assume that building / pushing was done manually using this script so far.

May I suggest to push a new interop runner on every push to master, or on a daily (?) cron job? GitHub Actions has some predefined workflows that should make building and pushing Docker images pretty straightforward. For inspiration, here is quic-go's workflow, and Quinn has one as well.

@mxinden
Copy link
Collaborator

mxinden commented Jan 14, 2024

I am happy to contribute the required GitHub Action in case there is interest from the neqo maintainers.

@martinthomson
Copy link
Member

@mxinden that would be great. I had a cron job setup, but I can supply the necessary secrets to get something running if you want to do the initial work. I remember having a bunch of problems with the docker hub setup at the time, so it might be easier to use the GitHub image store (I've moved to that for other projects).

@mxinden
Copy link
Collaborator

mxinden commented Jan 15, 2024

I prepared #1554. Let me know what you think.

mxinden added a commit to mxinden/quic-interop-runner that referenced this issue Jan 17, 2024
Neqo's interop runner Docker image is now hosted on GitHub's container registry
and continuously updated via a daily GitHub action.

See mozilla/neqo#1552 for details.
marten-seemann pushed a commit to quic-interop/quic-interop-runner that referenced this issue Jan 24, 2024
Neqo's interop runner Docker image is now hosted on GitHub's container registry
and continuously updated via a daily GitHub action.

See mozilla/neqo#1552 for details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants