Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): only take single url on (args.resume && first) #1578

Merged
merged 1 commit into from
Jan 23, 2024
Merged

fix(client): only take single url on (args.resume && first) #1578

merged 1 commit into from
Jan 23, 2024

Conversation

mxinden
Copy link
Collaborator

@mxinden mxinden commented Jan 23, 2024 •
edited
Loading

QUIC Interop Runner testcases resumption and 0-rtt expect the client to download the first file, close the connection, and then download the remaining files on a second connection.

https://github.com/quic-interop/quic-interop-runner/tree/master#test-cases

Thus neqo-client, when args.resume is true must only take a single URL on the first loop iteration. On the second iteration it must take all remaining URLs.

Regression introduced in #1569. My bad.

image

With this patch all, but the amplification testcase, are green. Note that the amplification testcase failed with the previous qns image as well. See https://interop.seemann.io/.

Received a 1337 byte Handshake packet from the server. Total: 5348
Server violated the amplification limit, but stayed within 3-4x amplification. Letting it slide.
Received a 1337 byte Handshake packet from the server. Total: 6685
Server violated the amplification limit.

Needed for quic-interop/quic-interop-runner#344.
Related to #1552.

@mxinden
fix(client): only take single url on (args.resume && first)
08bc808 
QUIC Interop Runner testcases `resumption` and `0-rtt` expect the client to
download the first file, close the connection, and then download the remaining
files on a second connection.

https://github.com/quic-interop/quic-interop-runner/tree/master#test-cases

Thus `neqo-client`, when `args.resume` is `true` must only take a single URL on
the **first** loop iteration. On the second iteration it must take all remaining
URLs.

Regression introduced in mozilla#1569.
martinthomson
martinthomson approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I missed that one.

@martinthomson martinthomson merged commit 6acf9ef into mozilla:main Jan 23, 2024
9 checks passed
@mxinden mxinden mentioned this pull request Jan 24, 2024
Merged
@mxinden mxinden mentioned this pull request Feb 26, 2024
Merged
@mxinden mxinden mentioned this pull request Mar 5, 2024
Open
mxinden added a commit to mxinden/neqo that referenced this pull request May 4, 2024
@mxinden
refactor: merge mozilla-central http3 server into neqo-bin
98b969e 
There are two server implementations based on neqo:

1. https://github.com/mozilla/neqo/tree/main/neqo-bin/src/server
  - http3 and http09 implementation
  - used for manual testing and QUIC Interop

2. https://searchfox.org/mozilla-central/source/netwerk/test/http3server/src/main.rs
  - used to test Firefox

I assume one was once an exact copy of the other. Both implement their own I/O,
event loop, ... Since then, the two implementations diverged significantly.
Especially (1) saw a lot of improvements in recent months:

- mozilla#1564
- mozilla#1569
- mozilla#1578
- mozilla#1581
- mozilla#1604
- mozilla#1612
- mozilla#1676
- mozilla#1692
- mozilla#1707
- mozilla#1708
- mozilla#1727
- mozilla#1753
- mozilla#1756
- mozilla#1766
- mozilla#1772
- mozilla#1786
- mozilla#1787
- mozilla#1788
- mozilla#1794
- mozilla#1806
- mozilla#1808
- mozilla#1848
- mozilla#1866

At this point, bugs in (2) are hard to fix, see e.g.
mozilla#1801.

This commit merges (2) into (1), thus removing all duplicate logic and
having (2) benefit from all the recent improvements to (1).
@mxinden mxinden mentioned this pull request May 4, 2024
Merged
KershawChang pushed a commit to KershawChang/neqo that referenced this pull request May 7, 2024
@mxinden @KershawChang
refactor: merge mozilla-central http3 server into neqo-bin
d1900d6 
There are two server implementations based on neqo:

1. https://github.com/mozilla/neqo/tree/main/neqo-bin/src/server
  - http3 and http09 implementation
  - used for manual testing and QUIC Interop

2. https://searchfox.org/mozilla-central/source/netwerk/test/http3server/src/main.rs
  - used to test Firefox

I assume one was once an exact copy of the other. Both implement their own I/O,
event loop, ... Since then, the two implementations diverged significantly.
Especially (1) saw a lot of improvements in recent months:

- mozilla#1564
- mozilla#1569
- mozilla#1578
- mozilla#1581
- mozilla#1604
- mozilla#1612
- mozilla#1676
- mozilla#1692
- mozilla#1707
- mozilla#1708
- mozilla#1727
- mozilla#1753
- mozilla#1756
- mozilla#1766
- mozilla#1772
- mozilla#1786
- mozilla#1787
- mozilla#1788
- mozilla#1794
- mozilla#1806
- mozilla#1808
- mozilla#1848
- mozilla#1866

At this point, bugs in (2) are hard to fix, see e.g.
mozilla#1801.

This commit merges (2) into (1), thus removing all duplicate logic and
having (2) benefit from all the recent improvements to (1).
github-merge-queue bot pushed a commit that referenced this pull request May 8, 2024
@mxinden
refactor: enable mozilla-central http3server to use neqo-bin (#1878)
b8ae981 
* refactor(bin): introduce server/http3.rs and server/http09.rs

The QUIC Interop Runner requires an http3 and http09 implementation for both
client and server. The client code is already structured into an http3 and an
http09 implementation since #1727.

This commit does the same for the server side, i.e. splits the http3 and http09
implementation into separate Rust modules.

* refactor: merge mozilla-central http3 server into neqo-bin

There are two server implementations based on neqo:

1. https://github.com/mozilla/neqo/tree/main/neqo-bin/src/server
  - http3 and http09 implementation
  - used for manual testing and QUIC Interop

2. https://searchfox.org/mozilla-central/source/netwerk/test/http3server/src/main.rs
  - used to test Firefox

I assume one was once an exact copy of the other. Both implement their own I/O,
event loop, ... Since then, the two implementations diverged significantly.
Especially (1) saw a lot of improvements in recent months:

- #1564
- #1569
- #1578
- #1581
- #1604
- #1612
- #1676
- #1692
- #1707
- #1708
- #1727
- #1753
- #1756
- #1766
- #1772
- #1786
- #1787
- #1788
- #1794
- #1806
- #1808
- #1848
- #1866

At this point, bugs in (2) are hard to fix, see e.g.
#1801.

This commit merges (2) into (1), thus removing all duplicate logic and
having (2) benefit from all the recent improvements to (1).

* Move firefox.rs to mozilla-central

* Reduce HttpServer trait functions

* Extract constructor

* Remove unused deps

* Remove clap color feature

Nice to have. Adds multiple dependencies. Hard to justify for mozilla-central.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinthomson martinthomson martinthomson approved these changes

@KershawChang KershawChang Awaiting requested review from KershawChang KershawChang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxinden @martinthomson