deps(quinn-udp): enable direct-log feature to log via log
#2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinn-rs/quinn#1923 made the `tracing` dependency optional. In addition, when `direct-log` is enabled, it allows using `log` instead of `tracing` for logging.
mxinden
requested review from
KershawChang,
martinthomson and
larseggert
as code owners
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2004 +/- ##
=======================================
Coverage 94.99% 94.99%
=======================================
Files 112 112
Lines 36371 36371
=======================================
Hits 34552 34552
Misses 1819 1819 ☔ View full report in Codecov by Sentry. |
Benchmark resultsPerformance differences relative to 88d3ed1. coalesce_acked_from_zero 1+1 entries: 💔 Performance has regressed. time: [193.82 ns 194.32 ns 194.86 ns]
change: [+1.0585% +1.4600% +1.8783%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 3+1 entries: 💔 Performance has regressed. time: [238.96 ns 239.56 ns 240.22 ns]
change: [+1.5087% +2.0000% +2.4562%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 10+1 entries: 💔 Performance has regressed. time: [239.02 ns 239.84 ns 240.81 ns]
change: [+1.1413% +1.8114% +2.3430%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 1000+1 entries: 💔 Performance has regressed. time: [222.11 ns 222.30 ns 222.52 ns]
change: [+1.0575% +1.6527% +2.2368%] (p = 0.00 < 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [119.73 ms 119.83 ms 119.92 ms]
change: [-0.9071% -0.6860% -0.5151%] (p = 0.00 < 0.05)
transfer/Run multiple transfers with varying seeds: No change in performance detected. time: [53.065 ms 56.547 ms 60.054 ms]
thrpt: [66.607 MiB/s 70.737 MiB/s 75.379 MiB/s]
change:
time: [-7.6013% +1.1634% +10.401%] (p = 0.79 > 0.05)
thrpt: [-9.4209% -1.1500% +8.2267%]
transfer/Run multiple transfers with the same seed: No change in performance detected. time: [69.133 ms 75.340 ms 81.496 ms]
thrpt: [49.082 MiB/s 53.093 MiB/s 57.860 MiB/s]
change:
time: [-10.206% +1.4040% +14.501%] (p = 0.82 > 0.05)
thrpt: [-12.665% -1.3846% +11.366%]
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected. time: [291.27 ms 297.38 ms 303.40 ms]
thrpt: [329.60 MiB/s 336.27 MiB/s 343.32 MiB/s]
change:
time: [-2.1438% +1.6573% +4.9678%] (p = 0.39 > 0.05)
thrpt: [-4.7327% -1.6303% +2.1908%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [406.46 ms 409.36 ms 412.22 ms]
thrpt: [24.259 Kelem/s 24.428 Kelem/s 24.603 Kelem/s]
change:
time: [-0.5202% +0.4932% +1.6615%] (p = 0.38 > 0.05)
thrpt: [-1.6344% -0.4908% +0.5230%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [68.522 ms 68.899 ms 69.323 ms]
thrpt: [14.425 elem/s 14.514 elem/s 14.594 elem/s]
change:
time: [+0.0098% +0.7534% +1.4934%] (p = 0.05 > 0.05)
thrpt: [-1.4714% -0.7478% -0.0098%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
larseggert
reviewed
Jul 23, 2024
larseggert
approved these changes
Jul 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains 3 commits, where the first two build up to the second:
[non-breaking] deps(udp): make tracing optional and add optional log quinn-rs/quinn#1923 made the
tracingdependency optional. In addition, whendirect-logis enabled, it allows usingloginstead oftracingfor logging.