[non-breaking] deps(udp): make tracing optional and add optional log #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the `tracing` dependency in `quinn-udp` optional, but enabled by default. In additional it adds optional logging via the `log` crate, enabled through the `direct-log` feature. `tracing` takes precedence over `native-log`.
mxinden
force-pushed
the
optional-tracing-non-breaking
branch
from
67b4325
to
46944db
Compare
mxinden
added a commit
to mxinden/quinn
that referenced
this pull request
Jul 22, 2024
Previously `quinn*` would provide the `log` feature to log events via `log` if no `tracing` subscriber exists. Later quinn-rs#1923 allowed `quinn-udp` to log via `log` directly, making `tracing` an optional dependency. For that, it introduced the `direct-log` feature, a workaround name in order to not introduce a breaking change. This commit cleans up the above, renaming the `log` feature to `tracing-log` and the `direct-log` to `log`. This is a breaking change and thus `quinn-udp` is bumped to `v0.6.0`. See quinn-rs#1921 for the full history.
This was referenced Jul 22, 2024
|
Sure, want to submit a PR to bump the version number? |
|
@djc already done in this pull request: https://github.com/quinn-rs/quinn/blob/main/quinn-udp/Cargo.toml#L3 |
|
Ah sorry, was looking at an outdated checkout. I'll just publish it now then! |
|
|
🙏 thanks again for the quick help @djc! |
mxinden
added a commit
to mxinden/neqo
that referenced
this pull request
Jul 23, 2024
quinn-rs/quinn#1923 made the `tracing` dependency optional. In addition, when `direct-log` is enabled, it allows using `log` instead of `tracing` for logging.
github-merge-queue bot
pushed a commit
to mozilla/neqo
that referenced
this pull request
Jul 23, 2024
* deps(quinn-udp): move to workspace dependency * deps(quinn-udp): bump to latest version * deps(quinn-udp): enable direct-log feature quinn-rs/quinn#1923 made the `tracing` dependency optional. In addition, when `direct-log` is enabled, it allows using `log` instead of `tracing` for logging.
github-merge-queue bot
pushed a commit
to mozilla/neqo
that referenced
this pull request
Jul 23, 2024
* deps(quinn-udp): move to workspace dependency * deps(quinn-udp): bump to latest version * deps(quinn-udp): enable direct-log feature quinn-rs/quinn#1923 made the `tracing` dependency optional. In addition, when `direct-log` is enabled, it allows using `log` instead of `tracing` for logging.
github-merge-queue bot
pushed a commit
to mozilla/neqo
that referenced
this pull request
Jul 23, 2024
* deps(quinn-udp): move to workspace dependency * deps(quinn-udp): bump to latest version * deps(quinn-udp): enable direct-log feature quinn-rs/quinn#1923 made the `tracing` dependency optional. In addition, when `direct-log` is enabled, it allows using `log` instead of `tracing` for logging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #1921.
Implementation of @Ralith suggestion in #1921 (comment).
Not breaking
quinn-udp. I.e. only bumping patch version tov0.5.3.