ci: unpin nss #2110
Closed
ci: unpin nss #2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4aa0319.
jschanck
requested review from
KershawChang,
martinthomson,
larseggert and
mxinden
as code owners
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2110 +/- ##
=======================================
Coverage 95.35% 95.35%
=======================================
Files 112 112
Lines 36325 36325
=======================================
Hits 34637 34637
Misses 1688 1688 ☔ View full report in Codecov by Sentry. |
Benchmark resultsPerformance differences relative to d4978de. coalesce_acked_from_zero 1+1 entries: Change within noise threshold. time: [99.693 ns 100.01 ns 100.36 ns]
change: [+0.0798% +0.5175% +1.0014%] (p = 0.03 < 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [117.95 ns 118.29 ns 118.65 ns]
change: [-0.1276% +0.4604% +0.9468%] (p = 0.09 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [117.53 ns 117.87 ns 118.32 ns]
change: [-0.2316% +0.4650% +1.0812%] (p = 0.17 > 0.05)
coalesce_acked_from_zero 1000+1 entries: Change within noise threshold. time: [98.579 ns 98.732 ns 98.902 ns]
change: [+0.6521% +1.5380% +2.4842%] (p = 0.00 < 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.45 ms 111.51 ms 111.57 ms]
change: [-0.5776% -0.3764% -0.2408%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [26.283 ms 27.205 ms 28.126 ms]
change: [-9.8545% -5.0715% -0.0275%] (p = 0.05 < 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [34.768 ms 36.362 ms 37.953 ms]
change: [-9.6389% -4.1373% +1.7435%] (p = 0.17 > 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [31.243 ms 32.045 ms 32.826 ms]
change: [-7.6161% -4.2222% -1.1332%] (p = 0.01 < 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [37.916 ms 40.484 ms 43.047 ms]
change: [-7.7034% +2.5078% +13.956%] (p = 0.65 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected. time: [112.36 ms 112.86 ms 113.34 ms]
thrpt: [882.32 MiB/s 886.03 MiB/s 889.97 MiB/s]
change:
time: [-0.7714% -0.2327% +0.2893%] (p = 0.42 > 0.05)
thrpt: [-0.2885% +0.2332% +0.7774%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [309.94 ms 313.56 ms 317.14 ms]
thrpt: [31.532 Kelem/s 31.892 Kelem/s 32.264 Kelem/s]
change:
time: [-1.7523% -0.2988% +1.2888%] (p = 0.72 > 0.05)
thrpt: [-1.2724% +0.2997% +1.7836%]
1-conn/1-1b-resp (aka. HPS)/client: Change within noise threshold. time: [34.111 ms 34.325 ms 34.559 ms]
thrpt: [28.936 elem/s 29.134 elem/s 29.316 elem/s]
change:
time: [+0.1877% +0.9730% +1.8019%] (p = 0.02 < 0.05)
thrpt: [-1.7700% -0.9636% -0.1874%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
|
Thanks! I prefer to go with #2108, since this PR reverts some changes I'd like to keep (like using the GitHub action to check out the source.) |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test to see if https://hg.mozilla.org/projects/nss/rev/18b287c5128e489b483cc156cdc7a51e41185c65 fixes the issue.