Merge #2333

2333: Remove check about Remote Settings version r=tiftran a=leplatrem Co-authored-by: Mathieu Leplatre <mathieu@mozilla.com>
mozilla · Dec 2, 2021 · 8f28b52 · 8f28b52
2 parents b173d6e + 7f51e02
commit 8f28b52
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 16 deletions.
diff --git a/normandy/recipes/exports.py b/normandy/recipes/exports.py
@@ -122,10 +122,6 @@ def check_config(self):
         if "signer" in capabilities:
             signer_config = capabilities["signer"]
 
-            # Since we use the rollback feature, make sure it's available.
-            if signer_config["version"] < "5.1.0":
-                raise ImproperlyConfigured("kinto-signer 5.1.0+ is required")
-
             normandy_resource = [
                 r
                 for r in signer_config["resources"]

diff --git a/normandy/recipes/tests/test_exports.py b/normandy/recipes/tests/test_exports.py
@@ -152,18 +152,6 @@ def test_check_connection(self, rs_settings, requestsmock):
         # restore write permissions
         requestsmock.get(collection_url, json=allow_write_payload)
 
-        # Signer version should be >= 5.1.0.
-        requestsmock.get(
-            f"{rs_settings.REMOTE_SETTINGS_URL}/",
-            json={
-                "user": {"id": f"account:{rs_settings.REMOTE_SETTINGS_USERNAME}"},
-                "capabilities": {"signer": {"version": "5.0.0"}},
-            },
-        )
-        with pytest.raises(ImproperlyConfigured) as exc:
-            exports.RemoteSettings().check_config()
-        assert "kinto-signer 5.1.0+ is required" in str(exc.value)
-
         # Capabilities collection review should be explicitly disabled.
         requestsmock.get(
             f"{rs_settings.REMOTE_SETTINGS_URL}/",