Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove check about Remote Settings version #2333

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Remove check about Remote Settings version #2333

merged 1 commit into from
Dec 2, 2021

Conversation

leplatrem
Copy link
Contributor

No description provided.

tiftran
tiftran approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@tiftran tiftran left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to be, but could we get a version for signer(I can create a github issue/bugzilla etc for a formal request)? If so, we could keep this check around, if version will be available again

@tiftran
Copy link
Contributor

tiftran commented Dec 2, 2021

bors merge

bors bot added a commit that referenced this pull request Dec 2, 2021
@bors @leplatrem
Merge #2333
8f28b52 
2333: Remove check about Remote Settings version r=tiftran a=leplatrem



Co-authored-by: Mathieu Leplatre <mathieu@mozilla.com>
@bors
Copy link
Contributor

bors bot commented Dec 2, 2021

Build failed:

@tiftran
Copy link
Contributor

tiftran commented Dec 2, 2021

bors retry

@bors
Copy link
Contributor

bors bot commented Dec 2, 2021

Build succeeded:

@bors bors bot merged commit de9221f into mozilla:master Dec 2, 2021
@leplatrem leplatrem deleted the remove-faulty-check-signer-rollback branch December 2, 2021 18:25
@leplatrem
Copy link
Contributor Author

Looks good to be, but could we get a version for signer(I can create a github issue/bugzilla etc for a formal request)? If so, we could keep this check around, if version will be available again

We will probably restore that version field, but the string comparison was dumb (my fault 😬) anyway.

I think the best way would be to rely no the server version directly, and not just the version of a plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiftran tiftran tiftran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leplatrem @tiftran