Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text Selection does not work as expected. #17368

Closed
x-wk opened this issue Dec 4, 2023 · 2 comments · Fixed by #17370
Closed

Text Selection does not work as expected. #17368

x-wk opened this issue Dec 4, 2023 · 2 comments · Fixed by #17370
Assignees

Comments

@x-wk
Copy link

x-wk commented Dec 4, 2023

Attach (recommended) or Link to PDF file here: https://mozilla.github.io/pdf.js/web/viewer.html

Configuration:

  • Web browser and its version: Edge
  • Operating system and its version: win10
  • PDF.js version:
  • Is a browser extension: false

Steps to reproduce the problem:

  1. Select ink editor
  2. Draw anything
  3. Scroll to last page
  4. Draw anything
  5. Cancel select ink editor
  6. Scroll to first page
  7. Text Selection does not work

What is the expected behavior? (add screenshot)

What went wrong? (add screenshot)

Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):

@SamsShow

This comment was marked as off-topic.

@Snuffleupagus
Copy link
Collaborator

Running git bisect points to PR #17330 being the culprit; /cc @calixteman

42147e88398a77394f06563765953da7f5cb3f11 is the first bad commit
commit 42147e88398a77394f06563765953da7f5cb3f11
Author: Calixte Denizet <calixte.denizet@gmail.com>
Date:   Fri Nov 24 16:00:00 2023 +0100

    [Editor] Only focus the canvas for mouse events when drawing in the canvas

    And if we've to focus it, we must prevent scrolling to avoid to draw at an
    unexpected position.

 src/display/editor/ink.js | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants