Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Only focus the canvas for mouse events when drawing in the canvas #17330

Merged
merged 1 commit into from
Nov 24, 2023
Merged

[Editor] Only focus the canvas for mouse events when drawing in the canvas #17330

merged 1 commit into from
Nov 24, 2023

Conversation

calixteman
Copy link
Contributor

And if we've to focus it, we must prevent scrolling to avoid to draw at an unexpected position.

@calixteman
[Editor] Only focus the canvas for mouse events when drawing in the c…
42147e8 
…anvas

And if we've to focus it, we must prevent scrolling to avoid to draw at an
unexpected position.
@calixteman calixteman linked an issue Nov 24, 2023 that may be closed by this pull request
Draweditor makes weird jumps when creating multiple annotations on different pages #17327
Closed
@Snuffleupagus
Copy link
Collaborator

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.241.84.105:8877/e9be8da15f90710/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/e9be8da15f90710/output.txt

Total script time: 1.39 mins

Published

Snuffleupagus
Snuffleupagus approved these changes Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you!

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/9d0f5b6496a8385/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/bb225bf70e47b06/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/bb225bf70e47b06/output.txt

Total script time: 8.18 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/9d0f5b6496a8385/output.txt

Total script time: 15.84 mins

  • Integration Tests: Passed

@calixteman calixteman merged commit 5831636 into mozilla:master Nov 24, 2023
9 checks passed
@calixteman calixteman deleted the issue17327 branch November 24, 2023 18:09
@calixteman calixteman mentioned this pull request Nov 27, 2023
Merged
@Snuffleupagus Snuffleupagus mentioned this pull request Dec 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Draweditor makes weird jumps when creating multiple annotations on different pages
3 participants
@calixteman @Snuffleupagus @moz-tools-bot