[TextLayer] Use Arrays to build the total transform and padding, rather than concatenating Strings, in expandTextDivs
#11089
Conversation
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/2095d49a67f294f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/6391fa06fdfa392/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/2095d49a67f294f/output.txt Total script time: 17.43 mins
Image differences available at: http://54.67.70.0:8877/2095d49a67f294f/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/6391fa06fdfa392/output.txt Total script time: 26.12 mins
Image differences available at: http://54.215.176.217:8877/6391fa06fdfa392/reftest-analyzer.html#web=eq.log |
|
Interestingly the only |
Given that browsers will reject padding values smaller than zero (which may be caused by limited numerical precision during calculations in the `expand` code), it makes no sense to include those when expanding the `textDiv`s.
…concatenating Strings, in `expandTextDivs` Furthermore, it's possible to re-use the same Array for all `textDiv`s on the page.
Snuffleupagus
force-pushed
the
textLayer-expandTextDivs
branch
from
96c031c
to
cf6626b
Compare
…ncatenating Strings, in `expandTextDivs` Furthermore, it's possible to re-use the same Array for all `textDiv`s on the page and the resulting padding string is also a lot more compact. Please note that the `paddingLeft` branch was moved, since the padding values need to be ordered as `top, right, bottom, left`. Finally, with this re-factoring it's no longer necessary to cache the original `style` string for every `textDiv` when `enhanceTextSelection` is enabled.
Snuffleupagus
force-pushed
the
textLayer-expandTextDivs
branch
from
cf6626b
to
2fb9d9b
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/42a61c16baf6d1b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/6cf365724c95680/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/42a61c16baf6d1b/output.txt Total script time: 17.46 mins
Image differences available at: http://54.67.70.0:8877/42a61c16baf6d1b/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/6cf365724c95680/output.txt Total script time: 26.03 mins
Image differences available at: http://54.215.176.217:8877/6cf365724c95680/reftest-analyzer.html#web=eq.log |
|
I'll try to submit these patches separately, to see if it's possible to pin-point where the movement in Chrome on Linux is coming from. |
This was split into PRs #11090, #11091, and #11092; please see #11092 (comment) which outlines the culprit. |
Please refer to the individual commit messages for additional details.