Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextLayer] Use an Array to build the total transform, rather than concatenating Strings, in expandTextDivs #11090

Merged

Conversation

Snuffleupagus
Copy link
Collaborator

Furthermore, it's possible to re-use the same Array for all textDivs on the page.

…concatenating Strings, in `expandTextDivs`

Furthermore, it's possible to re-use the same Array for all `textDiv`s on the page.
@Snuffleupagus Snuffleupagus force-pushed the textLayer-expandTextDivs-transform branch from 0f3a7d3 to 37e8a81 Compare August 23, 2019 10:17
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/364592d849edf7b/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/2590bf0eef18be0/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/364592d849edf7b/output.txt

Total script time: 17.40 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/2590bf0eef18be0/output.txt

Total script time: 26.03 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij timvandermeij merged commit edbebb8 into mozilla:master Aug 23, 2019
@timvandermeij
Copy link
Contributor

Nice patches on the performance of the text layer recently! I assume we can do the same for the padding strings here?

@Snuffleupagus
Copy link
Collaborator Author

Nice patches on the performance of the text layer recently!

Thank you!

I assume we can do the same for the padding strings here?

That's indeed the idea here, however I ran into some Linux/Chrome only test failures over in PR #11089 which is why I'm trying to split this into multiple PRs to hopefully get to the bottom of it.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants