Various smaller clean-up in gulpfile.js
#11869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ke sense Not only is there no code depending on it now, the actual task itself doesn't even make sense as-is. Note that it uses the default `DEFINES` configuration *unaltered*, which is neither useful nor correct since the resulting build thus won't make sense without an actual built target set.
…te ones for the main/worker-thread files All of the other *similar* helper functions only target one file per function, and there's no particular reason for this one to be different. This patch will simplify future changes, e.g. experimenting with using `gulp watch` instead of SystemJS for the development viewer.
Snuffleupagus
force-pushed
the
gulpfile-cleanup
branch
from
cacd43e
to
a9e7798
Compare
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/8163f906a3b7897/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/66ba5c465e0f4f6/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/8163f906a3b7897/output.txt Total script time: 3.51 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/66ba5c465e0f4f6/output.txt Total script time: 4.60 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/3580b060de9b18d/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/3580b060de9b18d/output.txt Total script time: 3.23 mins Published |
timvandermeij
approved these changes
May 3, 2020
|
Looks good; thanks! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to the individual commit messages.