Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various smaller clean-up in gulpfile.js #11869

Merged
merged 2 commits into from
May 3, 2020
Merged

Various smaller clean-up in gulpfile.js #11869

merged 2 commits into from
May 3, 2020

Commits on May 3, 2020

  1. Remove the gulp bundle task since it's unused and doesn't really ma… 

    …ke sense

Not only is there no code depending on it now, the actual task itself doesn't even make sense as-is. Note that it uses the default `DEFINES` configuration *unaltered*, which is neither useful nor correct since the resulting build thus won't make sense without an actual built target set.
    @Snuffleupagus
    Snuffleupagus committed May 3, 2020
    Configuration menu
    Copy the full SHA
    21495c1 View commit details
    Browse the repository at this point in the history

  2. Split the createBundle helper function, in gulpfile.js, into separa… 

    …te ones for the main/worker-thread files

All of the other *similar* helper functions only target one file per function, and there's no particular reason for this one to be different.
This patch will simplify future changes, e.g. experimenting with using `gulp watch` instead of SystemJS for the development viewer.
    @Snuffleupagus
    Snuffleupagus committed May 3, 2020
    Configuration menu
    Copy the full SHA
    a9e7798 View commit details
    Browse the repository at this point in the history