Enable/disable image smoothing based on image interpolate value. (bug 1722191) #13991

brendandahl · 2021-09-09T00:33:19Z

While some of the output looks worse to my eye, this behavior more
closely matches what I see when I open the PDFs in Adobe acrobat.

Fixes #4706
Fixes #9713
Fixes #8245
Fixes #1344
Fixes #5757

brendandahl · 2021-09-09T00:34:09Z

/botio test

pdfjsbot · 2021-09-09T00:34:10Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.241.84.105:8877/dcb67c58bc85309/output.txt

pdfjsbot · 2021-09-09T00:34:10Z

From: Bot.io (Windows)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.193.163.58:8877/c842147ac86d5d6/output.txt

brendandahl · 2021-09-09T00:38:02Z

For example:

pdfjsbot · 2021-09-09T00:56:06Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/dcb67c58bc85309/output.txt

Total script time: 21.93 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 529
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/dcb67c58bc85309/reftest-analyzer.html#web=eq.log

pdfjsbot · 2021-09-09T01:14:09Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/c842147ac86d5d6/output.txt

Total script time: 39.97 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 529
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/c842147ac86d5d6/reftest-analyzer.html#web=eq.log

brendandahl · 2021-09-09T02:02:04Z

A lot more failures on the bots than locally.

brendandahl · 2021-09-09T02:19:13Z

/botio test

pdfjsbot · 2021-09-09T02:19:15Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.241.84.105:8877/4c17cc59c1ded86/output.txt

pdfjsbot · 2021-09-09T02:19:15Z

From: Bot.io (Windows)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.193.163.58:8877/80201d8ee89a39a/output.txt

pdfjsbot · 2021-09-09T02:41:19Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/4c17cc59c1ded86/output.txt

Total script time: 22.06 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 354
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/4c17cc59c1ded86/reftest-analyzer.html#web=eq.log

pdfjsbot · 2021-09-09T02:59:25Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/80201d8ee89a39a/output.txt

Total script time: 40.16 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 353

Image differences available at: http://54.193.163.58:8877/80201d8ee89a39a/reftest-analyzer.html#web=eq.log

Snuffleupagus

While I completely agree that this looks good (or better) for most cases, even with the changes in the second commit there appear to be some regressions. (Also, please squash the commits before landing this.)

Looking through the test results, and focusing (only) on Firefox, there's a few cases that I do think look worse now when comparing against Adobe Reader:

issue3903, page1
freeculture, page2
wdsg_fitc, page20
cmykjpeg, page1
issue5644, page1
issue7200, page1; the "text" is a lot less readable
issue5549, page1
issue5475, page1
issue5481, all pages

Is there anything that could possibly be done about some of these cases, or are we going to have to accept those changes?

brendandahl · 2021-09-09T15:46:43Z

I'm looking into some heuristics. I was able to fix a few by following this comment, but there are still a few where acrobat seems to be doing some image smoothing in cases I wouldn't expect.

brendandahl · 2021-09-10T17:54:28Z

/botio test

pdfjsbot · 2021-09-10T17:54:30Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.241.84.105:8877/3d3dc844caf864e/output.txt

brendandahl · 2021-09-10T18:01:04Z

This will still need some tweaks. On a high dpi monitor the output now looks very close to acrobat, but on a monitor with a device pixel ratio of 1, pdf.js looks much worse than acrobat. I thought it was maybe do to pdf.js trying to draw images at fractional pixels, but even when I align the image to whole pixel values it still looks worse. I wonder if they're using a different scaling algorithm.

pdfjsbot · 2021-09-10T18:16:01Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/3d3dc844caf864e/output.txt

Total script time: 21.51 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  errors: 654
  different ref/snapshot: 88
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/3d3dc844caf864e/reftest-analyzer.html#web=eq.log

brendandahl · 2021-09-10T18:50:53Z

I think I may have figured it out, instead of comparing the scale to 1 we have to take into account that css pixels per inch are different than pdf pixels per inch. Using that value for deciding when to smooth seems to match acrobats behavior.

brendandahl · 2021-09-10T18:51:11Z

/botio test

pdfjsbot · 2021-09-10T18:51:12Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.241.84.105:8877/b3405493217d82f/output.txt

pdfjsbot · 2021-09-10T18:51:12Z

From: Bot.io (Windows)

Received

Command cmd_test from @brendandahl received. Current queue size: 1

Live output at: http://54.193.163.58:8877/7618d3c62bba454/output.txt

Snuffleupagus · 2021-09-10T19:00:34Z

src/display/canvas.js

+const CSS_PIXELS_PER_INCH = 96.0;
+const PDF_PIXELS_PER_INCH = 72.0;


Given how these values are being used, it appears (as far as I can tell) to be basically the following viewer constant:

pdf.js/web/ui_utils.js

Line 16 in 5678c75

const CSS_UNITS = 96.0 / 72.0;

Can we perhaps move the existing CSS_UNITS constant into display_utils.js (and export it via pdf.js) and then re-use here too, instead of essentially duplicating this?

Looking at the final patch, I've got one small suggestion for simplifying the new exports a little bit.
However, in the interest of getting this landed sooner rather than later, I'll merge it as-is and file a follow-up PR instead.

Snuffleupagus · 2021-09-10T19:03:16Z

src/display/canvas.js

+function getImageSmoothingEnabled(transform, interpolate) {
+  const scale = Util.singularValueDecompose2dScale(transform);
+  const actualScale =
+    (window.devicePixelRatio * CSS_PIXELS_PER_INCH) / PDF_PIXELS_PER_INCH;


This is causing the unit-tests to fail, when run in Node.js, since we cannot assume that window is defined.
How about simply doing (globalThis.devicePixelRatio || 1) * ... here, since that ought to prevent any issues?

pdfjsbot · 2021-09-10T19:16:21Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/b3405493217d82f/output.txt

Total script time: 25.15 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 78
  different first/second rendering: 3

Image differences available at: http://54.241.84.105:8877/b3405493217d82f/reftest-analyzer.html#web=eq.log

brendandahl · 2021-09-10T19:32:22Z

I need to look into why firefox-issue5549.pdf-page1 is blurry, locally (with lodpi and highdpi) it's getting smoothed in the viewer at 100%. I'm guessing something is different in test harness vs viewer.

… 1722191) While some of the output looks worse to my eye, this behavior more closely matches what I see when I open the PDFs in Adobe acrobat. Fixes: mozilla#4706, mozilla#9713, mozilla#8245, mozilla#1344

brendandahl · 2021-09-10T21:25:24Z

The issue with firefox-issue5549.pdf-page1 was a float rounding error, the scale's were both 1.333... but slightly different.

brendandahl · 2021-09-10T21:25:31Z

/botio test

pdfjsbot · 2021-09-10T21:25:32Z

From: Bot.io (Windows)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.193.163.58:8877/64e5c0427fdd0e9/output.txt

pdfjsbot · 2021-09-10T21:58:26Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/64e5c0427fdd0e9/output.txt

Total script time: 32.90 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  errors: 623
  different ref/snapshot: 34
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/64e5c0427fdd0e9/reftest-analyzer.html#web=eq.log

brendandahl · 2021-09-10T23:39:28Z

/botio-linux test

pdfjsbot · 2021-09-10T23:39:30Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.241.84.105:8877/04d1adaeccbeb8b/output.txt

pdfjsbot · 2021-09-11T00:01:43Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/04d1adaeccbeb8b/output.txt

Total script time: 22.22 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 53
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/04d1adaeccbeb8b/reftest-analyzer.html#web=eq.log

Snuffleupagus · 2021-09-11T06:52:00Z

/botio-windows browsertest

pdfjsbot · 2021-09-11T06:52:01Z

From: Bot.io (Windows)

Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/bd07d8d265ffcb5/output.txt

pdfjsbot · 2021-09-11T07:27:37Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/bd07d8d265ffcb5/output.txt

Total script time: 35.58 mins

Regression tests: FAILED

  different ref/snapshot: 74
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/bd07d8d265ffcb5/reftest-analyzer.html#web=eq.log

Snuffleupagus · 2021-09-11T07:48:16Z

/botio-linux preview

pdfjsbot · 2021-09-11T07:48:17Z

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1102bdb64794c67/output.txt

pdfjsbot · 2021-09-11T07:52:39Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/1102bdb64794c67/output.txt

Total script time: 4.35 mins

Published

Viewer: http://54.241.84.105:8877/1102bdb64794c67/web/viewer.html
Viewer (legacy): http://54.241.84.105:8877/1102bdb64794c67/legacy/web/viewer.html

Snuffleupagus

This looks much better, and fixes a bunch of old issues which is great; thank you!

Snuffleupagus · 2021-09-11T08:03:12Z

/botio makeref

pdfjsbot · 2021-09-11T08:03:13Z

From: Bot.io (Windows)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.193.163.58:8877/d9c648a3d312a27/output.txt

pdfjsbot · 2021-09-11T08:03:13Z

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/ebd544998cbce6b/output.txt

pdfjsbot · 2021-09-11T08:21:35Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/ebd544998cbce6b/output.txt

Total script time: 18.35 mins

Lint: Passed
Make references: FAILED

Snuffleupagus · 2021-09-11T08:24:43Z

/botio-linux makeref

pdfjsbot · 2021-09-11T08:24:45Z

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/6a4973df1f1f0bd/output.txt

pdfjsbot · 2021-09-11T08:43:13Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/6a4973df1f1f0bd/output.txt

Total script time: 18.47 mins

Lint: Passed
Make references: FAILED

pdfjsbot · 2021-09-11T08:44:35Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/d9c648a3d312a27/output.txt

Total script time: 36.28 mins

Lint: Passed
Make references: Passed
Check references: Passed

Snuffleupagus · 2021-09-11T09:01:20Z

/botio-linux makeref

pdfjsbot · 2021-09-11T09:01:21Z

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/fd69c212627b74d/output.txt

pdfjsbot · 2021-09-11T09:21:26Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/fd69c212627b74d/output.txt

Total script time: 20.07 mins

Lint: Passed
Make references: Passed
Check references: Passed

Snuffleupagus reviewed Sep 9, 2021

View reviewed changes

Snuffleupagus added image-quality image-conversion labels Sep 9, 2021

Snuffleupagus linked an issue Sep 9, 2021 that may be closed by this pull request

Image interpolation incorrect #9713

Closed

brendandahl force-pushed the interpolate branch from 653fab7 to 1ebb595 Compare September 10, 2021 17:54

brendandahl force-pushed the interpolate branch from 1ebb595 to 017ab04 Compare September 10, 2021 18:49

Snuffleupagus reviewed Sep 10, 2021

View reviewed changes

Enable/disable image smoothing based on image interpolate value. (bug…

f38fb42

… 1722191) While some of the output looks worse to my eye, this behavior more closely matches what I see when I open the PDFs in Adobe acrobat. Fixes: mozilla#4706, mozilla#9713, mozilla#8245, mozilla#1344

brendandahl force-pushed the interpolate branch from 017ab04 to f38fb42 Compare September 10, 2021 21:23

Snuffleupagus approved these changes Sep 11, 2021

View reviewed changes

Snuffleupagus merged commit 9ce63a6 into mozilla:master Sep 11, 2021

calixteman mentioned this pull request Nov 7, 2022

Rendering problems on Chrome - overlapping characters and not readable letters in default view #14641

Closed

calixteman mentioned this pull request Jan 31, 2024

Text or images in a pdf are loosing resolution, displaying in low quality #17599

Closed

This pull request was closed.

		const CSS_PIXELS_PER_INCH = 96.0;
		const PDF_PIXELS_PER_INCH = 72.0;

Enable/disable image smoothing based on image interpolate value. (bug 1722191) #13991

Enable/disable image smoothing based on image interpolate value. (bug 1722191) #13991

Conversation

brendandahl commented Sep 9, 2021 • edited by Snuffleupagus Loading

brendandahl commented Sep 9, 2021

pdfjsbot commented Sep 9, 2021

From: Bot.io (Linux m4)

Received

pdfjsbot commented Sep 9, 2021

From: Bot.io (Windows)

Received

brendandahl commented Sep 9, 2021

pdfjsbot commented Sep 9, 2021

From: Bot.io (Linux m4)

Failed

pdfjsbot commented Sep 9, 2021

From: Bot.io (Windows)

Failed

brendandahl commented Sep 9, 2021

brendandahl commented Sep 9, 2021

pdfjsbot commented Sep 9, 2021

From: Bot.io (Linux m4)

Received

pdfjsbot commented Sep 9, 2021

From: Bot.io (Windows)

Received

pdfjsbot commented Sep 9, 2021

From: Bot.io (Linux m4)

Failed

pdfjsbot commented Sep 9, 2021

From: Bot.io (Windows)

Failed

Snuffleupagus left a comment • edited Loading

Choose a reason for hiding this comment

brendandahl commented Sep 9, 2021

brendandahl commented Sep 10, 2021

pdfjsbot commented Sep 10, 2021

From: Bot.io (Linux m4)

Received

brendandahl commented Sep 10, 2021

pdfjsbot commented Sep 10, 2021

From: Bot.io (Linux m4)

Failed

brendandahl commented Sep 10, 2021

brendandahl commented Sep 10, 2021

pdfjsbot commented Sep 10, 2021

From: Bot.io (Linux m4)

Received

pdfjsbot commented Sep 10, 2021

From: Bot.io (Windows)

Received

Snuffleupagus Sep 10, 2021

Choose a reason for hiding this comment

Snuffleupagus Sep 11, 2021

Choose a reason for hiding this comment

Snuffleupagus Sep 10, 2021 • edited Loading

Choose a reason for hiding this comment

pdfjsbot commented Sep 10, 2021

From: Bot.io (Linux m4)

Failed

brendandahl commented Sep 10, 2021

brendandahl commented Sep 10, 2021

brendandahl commented Sep 10, 2021

pdfjsbot commented Sep 10, 2021

From: Bot.io (Windows)

Received

pdfjsbot commented Sep 10, 2021

From: Bot.io (Windows)

Failed

brendandahl commented Sep 10, 2021

pdfjsbot commented Sep 10, 2021

From: Bot.io (Linux m4)

Received

pdfjsbot commented Sep 11, 2021

From: Bot.io (Linux m4)

Failed

Snuffleupagus commented Sep 11, 2021

pdfjsbot commented Sep 11, 2021

From: Bot.io (Windows)

Received

brendandahl commented Sep 9, 2021 •

edited by Snuffleupagus

Loading

Snuffleupagus left a comment •

edited

Loading

Snuffleupagus Sep 10, 2021 •

edited

Loading