Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary font-size CSS rule from the html element (issue 14555, PR 3794 follow-up) #14557

Merged
merged 1 commit into from
Feb 13, 2022

Conversation

Snuffleupagus
Copy link
Collaborator

According to #3794 (comment) this was intended to be temporary, and the B2G project itself was discontinued years ago.

…e 14555, PR 3794 follow-up)

According to mozilla#3794 (comment) this was intended to be *temporary*, and the B2G project itself was discontinued years ago.
@Snuffleupagus
Copy link
Collaborator Author

As far as I can tell, nothing in the default viewer should depend on this CSS rule. However, additional testing would be most welcome!

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/055dce85f012688/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/055dce85f012688/output.txt

Total script time: 2.65 mins

Published

@timvandermeij timvandermeij merged commit 99fde3c into mozilla:master Feb 13, 2022
@timvandermeij
Copy link
Contributor

I also can't spot any part of the viewer needing this, and given that it was temporary in the first place, I'd say this is fine. Thanks!

@Snuffleupagus Snuffleupagus deleted the issue-14555 branch February 13, 2022 13:33
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10px font size on html element in viewer.css makes for challenging styling
3 participants