Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the B2G viewer and enable bot preview. #3794

Merged
merged 1 commit into from
Oct 17, 2013

Conversation

brendandahl
Copy link
Contributor

If you want to test locally you can grab the folder https://github.com/mozilla/botio-files-pdfjs/tree/master/b2g_stubs , rename it to shared and put it in the root folder of your server.

@brendandahl
Copy link
Contributor Author

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Oct 9, 2013

From: Bot.io (Linux)


Received

Command cmd_preview from @brendandahl received. Current queue size: 0

Live output at: http://107.21.233.14:8877/f8e2e0df5f9a542/output.txt

@timvandermeij
Copy link
Contributor

Really nice work! Now I can finally test my changes in the B2G viewer, because I couldn't get it to work locally.

Question though: was the branch you created at https://github.com/mozilla/pdf.js/tree/b2g-fix (so in the PDF.js repo, not your local fork) on purpose or simply a wrong push? Just making sure you know it's there :)

@brendandahl
Copy link
Contributor Author

Wrong push, should be gone now.

@brendandahl
Copy link
Contributor Author

@timvandermeij see bug description(just edited), should be able to test locally now too.

@@ -20,6 +20,8 @@

html {
height: 100%;
/* Font size is needed to make the activity bar the corect size. */
font-size: 10px;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These came from https://github.com/mozilla-b2g/gaia/blob/master/apps/pdfjs/content/web/viewer-b2g.css which I'll be removing in the next update.

brendandahl added a commit that referenced this pull request Oct 17, 2013
Fix the B2G viewer and enable bot preview.
@brendandahl brendandahl merged commit ca18060 into mozilla:master Oct 17, 2013
Snuffleupagus added a commit to Snuffleupagus/pdf.js that referenced this pull request Feb 11, 2022
…e 14555, PR 3794 follow-up)

According to mozilla#3794 (comment) this was intended to be *temporary*, and the B2G project itself was discontinued years ago.
bh213 pushed a commit to bh213/pdf.js that referenced this pull request Jun 3, 2022
…e 14555, PR 3794 follow-up)

According to mozilla#3794 (comment) this was intended to be *temporary*, and the B2G project itself was discontinued years ago.
rousek pushed a commit to signosoft/pdf.js that referenced this pull request Aug 10, 2022
…e 14555, PR 3794 follow-up)

According to mozilla#3794 (comment) this was intended to be *temporary*, and the B2G project itself was discontinued years ago.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants