-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the B2G viewer and enable bot preview. #3794
Conversation
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @brendandahl received. Current queue size: 0 Live output at: http://107.21.233.14:8877/f8e2e0df5f9a542/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/f8e2e0df5f9a542/output.txt Total script time: 0.25 mins Published
|
Really nice work! Now I can finally test my changes in the B2G viewer, because I couldn't get it to work locally. Question though: was the branch you created at https://github.com/mozilla/pdf.js/tree/b2g-fix (so in the PDF.js repo, not your local fork) on purpose or simply a wrong push? Just making sure you know it's there :) |
Wrong push, should be gone now. |
@timvandermeij see bug description(just edited), should be able to test locally now too. |
@@ -20,6 +20,8 @@ | |||
|
|||
html { | |||
height: 100%; | |||
/* Font size is needed to make the activity bar the corect size. */ | |||
font-size: 10px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These came from https://github.com/mozilla-b2g/gaia/blob/master/apps/pdfjs/content/web/viewer-b2g.css which I'll be removing in the next update.
Fix the B2G viewer and enable bot preview.
…e 14555, PR 3794 follow-up) According to mozilla#3794 (comment) this was intended to be *temporary*, and the B2G project itself was discontinued years ago.
…e 14555, PR 3794 follow-up) According to mozilla#3794 (comment) this was intended to be *temporary*, and the B2G project itself was discontinued years ago.
…e 14555, PR 3794 follow-up) According to mozilla#3794 (comment) this was intended to be *temporary*, and the B2G project itself was discontinued years ago.
If you want to test locally you can grab the folder https://github.com/mozilla/botio-files-pdfjs/tree/master/b2g_stubs , rename it to
shared
and put it in the root folder of your server.