[api-minor] Further modernize the ProgressBar class (PR 14918 follow-up)
#15121
Conversation
…w-up) - Simplify how we look-up the DOM-element, which should also be a tiny bit more efficent. - Use private class-fields, rather than property-names prefixed with underscores. - Inline the `#updateBar` helper-method directly in the `percent`-setter, since having a separate method doesn't seem necessary in this case. - Set the `indeterminate`-class on the ProgressBar DOM-element, to simplify the code. Finally, also (slightly) re-factors the `PDFViewerApplication.progress`-method to make it a bit smaller.
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/22c9ce6375eccb5/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/1568272d7014980/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/1568272d7014980/output.txt Total script time: 4.73 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/22c9ce6375eccb5/output.txt Total script time: 7.63 mins
|
| @@ -718,7 +718,7 @@ const PDFViewerApplication = { | |||
| }, | |||
|
|
|||
| get loadingBar() { | |||
| const bar = new ProgressBar("#loadingBar"); | |||
| const bar = new ProgressBar("loadingBar"); | |||
| return shadow(this, "loadingBar", bar); | |||
There was a problem hiding this comment.
This is unrelated to this patch, does it make sense to shadow the value ?
I suppose that once the document is loaded we don't need it anymore.
There was a problem hiding this comment.
This is unrelated to this patch, does it make sense to shadow the value ?
Doing that simplifies the code overall, and also allows us to initialize it lazily, since we're accessing it from multiple spots throughout the viewer code; see e.g.
Lines 1163 to 1164 in 13c01b6
Lines 1180 to 1183 in 13c01b6
Line 1196 in 13c01b6
Line 1255 in 13c01b6
I suppose that once the document is loaded we don't need it anymore.
Correct; however if we'd remove it at the end of loading that'd (as far as I can tell) either mean having to initialize it eagerly or possibly require adding more code.
Simplify how we look-up the DOM-element, which should also be a tiny bit more efficent.
Use private class-fields, rather than property-names prefixed with underscores.
Inline the
#updateBarhelper-method directly in thepercent-setter, since having a separate method doesn't seem necessary in this case.Set the
indeterminate-class on the ProgressBar DOM-element, to simplify the code.Finally, also (slightly) re-factors the
PDFViewerApplication.progress-method to make it a bit smaller.