Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api-minor] Further modernize the ProgressBar class (PR 14918 follow-up) #15121

Merged
merged 1 commit into from
Jul 2, 2022

Commits on Jul 1, 2022

  1. [api-minor] Further modernize the ProgressBar class (PR 14918 follo…

    …w-up)
    
     - Simplify how we look-up the DOM-element, which should also be a tiny bit more efficent.
    
     - Use private class-fields, rather than property-names prefixed with underscores.
    
     - Inline the `#updateBar` helper-method directly in the `percent`-setter, since having a separate method doesn't seem necessary in this case.
    
     - Set the `indeterminate`-class on the ProgressBar DOM-element, to simplify the code.
    
    Finally, also (slightly) re-factors the `PDFViewerApplication.progress`-method to make it a bit smaller.
    Snuffleupagus committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    d9ce176 View commit details
    Browse the repository at this point in the history