Introduce a "thumbnailrendered" event to simplify cleanup after thumbnail rendering (PR 12613 follow-up) #16470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nail rendering (PR 12613 follow-up) The way that the cleanup was implemented in PR 12613 has always bothered me slightly, since the `isPageCached`-method that I introduced there always felt quite out-of-place in the `IPDFLinkService`-implementations. By introducing a new "thumbnailrendered" event, similar to the existing "pagerendered" one, we're able to move the cleanup handling into the `PDFViewer`-class instead.
Snuffleupagus
force-pushed
the
thumbnailrendered-event
branch
from
28fbd0f
to
bc8523a
Compare
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/77db3d7e65ae36b/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/780596ead742b56/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/780596ead742b56/output.txt Total script time: 3.62 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/77db3d7e65ae36b/output.txt Total script time: 15.57 mins
|
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/53218d32585b947/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/53218d32585b947/output.txt Total script time: 1.29 mins Published |
timvandermeij
approved these changes
May 28, 2023
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way that the cleanup was implemented in PR #12613 has always bothered me slightly, since the
isPageCached-method that I introduced there always felt quite out-of-place in theIPDFLinkService-implementations.By introducing a new "thumbnailrendered" event, similar to the existing "pagerendered" one, we're able to move the cleanup handling into the
PDFViewer-class instead.