Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a "thumbnailrendered" event to simplify cleanup after thumbnail rendering (PR 12613 follow-up) #16470

Merged
merged 1 commit into from
May 28, 2023
Merged

Introduce a "thumbnailrendered" event to simplify cleanup after thumbnail rendering (PR 12613 follow-up) #16470

merged 1 commit into from
May 28, 2023

Commits on May 26, 2023

  1. Introduce a "thumbnailrendered" event to simplify cleanup after thumb… 

    …nail rendering (PR 12613 follow-up)

The way that the cleanup was implemented in PR 12613 has always bothered me slightly, since the `isPageCached`-method that I introduced there always felt quite out-of-place in the `IPDFLinkService`-implementations.
By introducing a new "thumbnailrendered" event, similar to the existing "pagerendered" one, we're able to move the cleanup handling into the `PDFViewer`-class instead.
    @Snuffleupagus
    Snuffleupagus committed May 26, 2023
    Configuration menu
    Copy the full SHA
    bc8523a View commit details
    Browse the repository at this point in the history