Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the getUuid helper function #19084

Merged
merged 1 commit into from
Nov 21, 2024

Commits on Nov 21, 2024

  1. Simplify the getUuid helper function

    We can remove most feature testing from this helper function, with the exception of `randomUUID` since that's only available in "secure contexts", and also remove the fallback code-path.
    Note that this code was only added for Node.js compatibility, and it's no longer necessary now that the minimum support version is `20`; see also https://developer.mozilla.org/en-US/docs/Web/API/Crypto#browser_compatibility
    
    Finally, this patch also adds a basic unit-test for the helper function.
    Snuffleupagus committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    c290a12 View commit details
    Browse the repository at this point in the history